Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db migration #960

Merged
merged 5 commits into from Jan 12, 2024
Merged

fix: db migration #960

merged 5 commits into from Jan 12, 2024

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jan 12, 2024

I encountered three issues while upgrading a database with db revisions ad98460751d9 and c349f52c700d.

PR moved from #948.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review January 12, 2024 14:15
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Ahmad-Wahid
Copy link
Contributor

Upgradation was successful.

@Flix6x Flix6x merged commit d4e6480 into main Jan 12, 2024
9 checks passed
@Flix6x Flix6x deleted the fix/db-migrations-2 branch January 12, 2024 15:58
@Flix6x
Copy link
Contributor Author

Flix6x commented Jan 12, 2024

Thanks for reviewing and testing!

Flix6x added a commit that referenced this pull request Jan 12, 2024
* fix: db migration

Signed-off-by: F.N. Claessen <felix@seita.nl>

* style: black

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: db session should close to speed up dropping indices

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry and update warning for 0.18.0

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upgrading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants