Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use storage efficiency quantity or sensor #965

Merged

Conversation

victorgarcia98
Copy link
Contributor

@victorgarcia98 victorgarcia98 commented Jan 26, 2024

Description

This PR allows the user to use the storage efficiency from a sensor.

There is a detail to be discussed. In case of a fix value, we assume that the timeframe of the efficiency corresponds to the resolution of the sensor. In case of the sensor, this PR assumes a similar thing.


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/data/schemas/sensors.py Show resolved Hide resolved
flexmeasures/data/models/planning/tests/test_solver.py Outdated Show resolved Hide resolved
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
victorgarcia98 and others added 3 commits January 31, 2024 23:25
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@Flix6x Flix6x added this to the 0.19.0 milestone Feb 5, 2024
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@victorgarcia98 victorgarcia98 merged commit 199bd95 into main Feb 6, 2024
9 checks passed
@victorgarcia98 victorgarcia98 deleted the feature/planning/storage-efficiency-from-sensor branch February 6, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants