hotfix/convert capacity to MW #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
victorgarcia98
added
bug
Flix6x
approved these changes
Feb 15, 2024
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
|
@nhoening for the release, when editing the changelog, please move this changelog entry to 0.18.2. |
Flix6x
pushed a commit
that referenced
this pull request
Feb 26, 2024
* convert capacity to MW Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * add changelog entry Signed-off-by: Victor Garcia Reolid <victor@seita.nl> --------- Signed-off-by: Victor Garcia Reolid <victor@seita.nl> Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The power limits were converted to the units of the power storage sensor. Luckily, as the current
StorageSchedulerdoesn't support non-MW units, this issue hasn't pop up yet.Further Improvements
MW. A unit test cannot be added for now because we don't support scheduling power sensors with unitsRelated Items
Important
This PR needs to be backported to version 0.18.X