Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get public assets #995

Merged
merged 5 commits into from
Mar 1, 2024
Merged

get public assets #995

merged 5 commits into from
Mar 1, 2024

Conversation

victorgarcia98
Copy link
Contributor

Note

This PR needs to be backported to version v.0.19.X

Description

This PR introduces a fix to the bug in #991, which describes that the asset page for public assets doesn't work.

Related Items

Closes #991

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98 victorgarcia98 self-assigned this Feb 29, 2024
@victorgarcia98 victorgarcia98 linked an issue Feb 29, 2024 that may be closed by this pull request
Public asset cannot be displayed #991
Closed
@victorgarcia98 @Flix6x
Update flexmeasures/ui/utils/breadcrumb_utils.py
537940e 
Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: Victor <victorgarciareolid98@gmail.com>
@victorgarcia98 victorgarcia98 marked this pull request as ready for review February 29, 2024 20:01
@Flix6x
fix: db query
81d8afb 
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
Flix6x requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one more fix, because the db query wasn't functioning properly. Finally, I noticed that the PUBLIC entity in the breadcrumb has a dropdown caret for some reason. Do you see that, too? Could be a separate issue, unless it's easy to tackle here.

@Flix6x Flix6x added this to the 0.19.2 milestone Feb 29, 2024
@Flix6x
Merge remote-tracking branch 'origin/main' into 991-public-asset-cann…
35d459b 
…ot-be-displayed
@Flix6x
docs: changelog entry
330ddd4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 4446e1f into main Mar 1, 2024
7 of 9 checks passed
@Flix6x Flix6x deleted the 991-public-asset-cannot-be-displayed branch March 1, 2024 10:15
Flix6x added a commit that referenced this pull request Mar 1, 2024
@victorgarcia98 @Flix6x
Backport PR #995: get public assets (#995)
d55d8e0 
* get public assets

* Update flexmeasures/ui/utils/breadcrumb_utils.py

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: Victor <victorgarciareolid98@gmail.com>

* fix: db query

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: Victor <victorgarciareolid98@gmail.com>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

@nhoening nhoening Awaiting requested review from nhoening

Assignees

@victorgarcia98 victorgarcia98

Labels
bug Something isn't working UI
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.

Public asset cannot be displayed
2 participants
@victorgarcia98 @Flix6x