Update tutorial screenshots #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ahmad-Wahid
commented
May 18, 2023
Ahmad-Wahid
commented
- Added new asset view with and without data .
- New screenshot of battery discharge.
- Updated day-ahead-prices screenshot.
…arging screenshot Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
|
Quick comment: If we rename screenshots, older versions of the documentation will not show properly anymore. In a perfect world, we'd find a way to manage the screenshots in a different way, but there is no perfect design we can think of. Why do we need screenshots without data anyway? |
|
I added it because, if you look at the first asset screenshot in the tutorial, it just shows the battery sensor, location, and editing options of the asset. |
…olar addition Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
nhoening
requested changes
May 18, 2023
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Flix6x
reviewed
May 19, 2023
There was a problem hiding this comment.
Looks good.
Note that in FlexMeasures/flexmeasures#687 I request one extra screenshot, so you might as well include it in this PR.
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Flix6x
approved these changes
May 22, 2023
Signed-off-by: Ahmad Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>
nhoening
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.