fixed method "resetLayer" in terms of deleting layer labels #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the layer settings triggers the
base-layer/leafletOptionsDidChange
handler, which executes_resetLayer->_destroyLayer->
_removeLayerFromLeafletContainer,removing the previous leafletLayer instance from the leafletContainer
this.get('_labelsLayer')
of labels is a linked separate layer withthis.get('_leafletObject')
and will be removed only when
this.get('labelSettings.signMapObjects') === true
But
this.get('labelSettings.signMapObjects')
can be changed BEFORE _resetLayer, which will leavethis.get('_labelsLayer')
in the leafletContainer.It is necessary to remove
this.get('_labelsLayer')
from the leafletContainer whenever _removeLayerFromLeafletContainer is called