make_rss causes unexpected crash

[dinsdalepiranha]

Just upgraded Flexget from 2.10.94 to 3.11.13 and everything works unless I try to use make_rss in which case 'execute' throws all of this for every instance of make_rss:

2024-01-28 20:40:55 CRITICAL task          series-notifications BUG: Unhandled error in plugin make_rss: (sqlite3.OperationalError) no such column: make_rss.enc_length
[SQL: SELECT make_rss.id AS make_rss_id, make_rss.title AS make_rss_title, make_rss.description AS make_rss_description, make_rss.link AS make_rss_link, make_rss.rsslink AS make_rss_rsslink, make_rss.file AS make_rss_file, make_rss.published AS make_rss_published, make_rss.enc_length AS make_rss_enc_length, make_rss.enc_type AS make_rss_enc_type 
FROM make_rss 
WHERE make_rss.file = ? ORDER BY make_rss.published DESC]
[parameters: ('/var/www/html/fg/fg.rss',)]
(Background on this error at: https://sqlalche.me/e/20/e3q8)
Traceback (most recent call last):

  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1969, in _exec_single_context
    self.dialect.do_execute(
    │    │       └ <function DefaultDialect.do_execute at 0x7f38297a60c0>
    │    └ <sqlalchemy.dialects.sqlite.pysqlite.SQLiteDialect_pysqlite object at 0x7f38252c69d0>
    └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/default.py", line 922, in do_execute
    cursor.execute(statement, parameters)
    │      │       │          └ ('/var/www/html/fg/fg.rss',)
    │      │       └ 'SELECT make_rss.id AS make_rss_id, make_rss.title AS make_rss_title, make_rss.description AS make_rss_description, make_rss....
    │      └ <method 'execute' of 'sqlite3.Cursor' objects>
    └ <sqlite3.Cursor object at 0x7f3824643140>

sqlite3.OperationalError: no such column: make_rss.enc_length


The above exception was the direct cause of the following exception:


Traceback (most recent call last):

  File "/usr/lib/python3.11/threading.py", line 1002, in _bootstrap
    self._bootstrap_inner()
    │    └ <function Thread._bootstrap_inner at 0x7f382b001760>
    └ <Thread(task_queue, started daemon 139879114483392)>
  File "/usr/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
    self.run()
    │    └ <function Thread.run at 0x7f382b001440>
    └ <Thread(task_queue, started daemon 139879114483392)>
  File "/usr/lib/python3.11/threading.py", line 982, in run
    self._target(*self._args, **self._kwargs)
    │    │        │    │        │    └ {}
    │    │        │    │        └ <Thread(task_queue, started daemon 139879114483392)>
    │    │        │    └ ()
    │    │        └ <Thread(task_queue, started daemon 139879114483392)>
    │    └ <bound method TaskQueue.run of <flexget.task_queue.TaskQueue object at 0x7f38252d19d0>>
    └ <Thread(task_queue, started daemon 139879114483392)>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/task_queue.py", line 46, in run
    self.current_task.execute()
    │    │            └ <function Task.execute at 0x7f382836cd60>
    │    └ <flexget.task.Task object at 0x7f38250b46d0>
    └ <flexget.task_queue.TaskQueue object at 0x7f38252d19d0>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/task.py", line 87, in wrapper
    return func(self, *args, **kw)
           │    │      │       └ {}
           │    │      └ ()
           │    └ <flexget.task.Task object at 0x7f38250b46d0>
           └ <function Task.execute at 0x7f382836ccc0>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/task.py", line 722, in execute
    self._execute()
    │    └ <function Task._execute at 0x7f382836cc20>
    └ <flexget.task.Task object at 0x7f38250b46d0>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/task.py", line 691, in _execute
    self.__run_task_phase(phase)
    │                     └ 'exit'
    └ <flexget.task.Task object at 0x7f38250b46d0>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/task.py", line 514, in __run_task_phase
    response = self.__run_plugin(plugin, phase, args)
               │                 │       │      └ (<flexget.task.Task object at 0x7f38250b46d0>, '/var/www/html/fg/fg.rss')
               │                 │       └ 'exit'
               │                 └ <PluginInfo(name=make_rss)>
               └ <flexget.task.Task object at 0x7f38250b46d0>
> File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/task.py", line 547, in __run_plugin
    result = method(*args, **kwargs)
             │       │       └ {}
             │       └ (<flexget.task.Task object at 0x7f38250b46d0>, '/var/www/html/fg/fg.rss')
             └ <Event(name=plugin.make_rss.exit,func=on_task_exit,priority=128)>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/event.py", line 20, in __call__
    return self.func(*args, **kwargs)
           │    │     │       └ {}
           │    │     └ (<flexget.task.Task object at 0x7f38250b46d0>, '/var/www/html/fg/fg.rss')
           │    └ <bound method OutputRSS.on_task_exit of <flexget.plugins.output.rss.OutputRSS object at 0x7f38257d0750>>
           └ <Event(name=plugin.make_rss.exit,func=on_task_exit,priority=128)>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/flexget/plugins/output/rss.py", line 237, in on_task_exit
    .all()
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/orm/query.py", line 2693, in all
    return self._iter().all()  # type: ignore
           │    └ <function Query._iter at 0x7f3829321300>
           └ <sqlalchemy.orm.query.Query object at 0x7f3824ee9ed0>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/orm/query.py", line 2847, in _iter
    result: Union[ScalarResult[_T], Result[_T]] = self.session.execute(
            │                  │    │      │      │    │       └ <function Session.execute at 0x7f38293b93a0>
            │                  │    │      │      │    └ <sqlalchemy.orm.session.ContextSession object at 0x7f38245ff750>
            │                  │    │      │      └ <sqlalchemy.orm.query.Query object at 0x7f3824ee9ed0>
            │                  │    │      └ ~_T
            │                  │    └ <class 'sqlalchemy.engine.result.Result'>
            │                  └ ~_T
            └ typing.Union
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/orm/session.py", line 2308, in execute
    return self._execute_internal(
           │    └ <function Session._execute_internal at 0x7f38293b9080>
           └ <sqlalchemy.orm.session.ContextSession object at 0x7f38245ff750>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/orm/session.py", line 2190, in _execute_internal
    result: Result[Any] = compile_state_cls.orm_execute_statement(
                   │      │                 └ <classmethod(<function AbstractORMCompileState.orm_execute_statement at 0x7f3829435e40>)>
                   │      └ <class 'sqlalchemy.orm.context.ORMSelectCompileState'>
                   └ typing.Any
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/orm/context.py", line 293, in orm_execute_statement
    result = conn.execute(
             │    └ <function Connection.execute at 0x7f38298d6200>
             └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1416, in execute
    return meth(
           └ <bound method ClauseElement._execute_on_connection of <sqlalchemy.sql.selectable.Select object at 0x7f3824665c90>>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/sql/elements.py", line 517, in _execute_on_connection
    return connection._execute_clauseelement(
           │          └ <function Connection._execute_clauseelement at 0x7f38298d6520>
           └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1639, in _execute_clauseelement
    ret = self._execute_context(
          │    └ <function Connection._execute_context at 0x7f38298d6700>
          └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1848, in _execute_context
    return self._exec_single_context(
           │    └ <function Connection._exec_single_context at 0x7f38298d67a0>
           └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1988, in _exec_single_context
    self._handle_dbapi_exception(
    │    └ <function Connection._handle_dbapi_exception at 0x7f38298d6a20>
    └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 2344, in _handle_dbapi_exception
    raise sqlalchemy_exception.with_traceback(exc_info[2]) from e
          │                    │              │                 └ OperationalError('no such column: make_rss.enc_length')
          │                    │              └ (<class 'sqlite3.OperationalError'>, OperationalError('no such column: make_rss.enc_length'), <traceback object at 0x7f38250b...
          │                    └ <method 'with_traceback' of 'BaseException' objects>
          └ OperationalError('(sqlite3.OperationalError) no such column: make_rss.enc_length')
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1969, in _exec_single_context
    self.dialect.do_execute(
    │    │       └ <function DefaultDialect.do_execute at 0x7f38297a60c0>
    │    └ <sqlalchemy.dialects.sqlite.pysqlite.SQLiteDialect_pysqlite object at 0x7f38252c69d0>
    └ <sqlalchemy.engine.base.Connection object at 0x7f3824665e10>
  File "/home/username/.local/share/pipx/venvs/flexget/lib/python3.11/site-packages/sqlalchemy/engine/default.py", line 922, in do_execute
    cursor.execute(statement, parameters)
    │      │       │          └ ('/var/www/html/fg/fg.rss',)
    │      │       └ 'SELECT make_rss.id AS make_rss_id, make_rss.title AS make_rss_title, make_rss.description AS make_rss_description, make_rss....
    │      └ <method 'execute' of 'sqlite3.Cursor' objects>
    └ <sqlite3.Cursor object at 0x7f3824643140>

sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: make_rss.enc_length

[gazpachoking]

Hmm, seems that when #2324 got merged it didn't include the database migration to add those columns. Probably the easiest solution is to clear the database for make_rss and let it get recreated. flexget database reset-plugin make_rss This will cause the current history in your rss to go away, but should fix things going forward. Technically we should add a database migration to fix this, but I bet there are very few people still upgrading from that old version (other than you) for it to matter.