Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rss plugin: all_entries:no now issues warning #143

Closed
ghost opened this issue Jan 11, 2014 · 5 comments
Closed

rss plugin: all_entries:no now issues warning #143

ghost opened this issue Jan 11, 2014 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 11, 2014

When using all_entries:no for rss plugin, it didn't used to produce a warning when there were no new entries. Now every time a feed is run and there are no new entries (which happens a lot), this error is in the logs:

Task didn't produce any entries. This is likely due to a mis-configured or non-functional input.

My logs show this started on January 3, so it was a change on or before then.
@theaquamarine
Copy link
Member

e821e53 is responsible for it being a warning rather than verbose event, but that doesn't explain why this is happening- with all_entries off, no_entries_ok should be on, causing this message to never appear. I'd guess there's some path through rss where no_entries_ok doesn't get set?

theaquamarine added a commit to theaquamarine/Flexget that referenced this issue Jan 11, 2014
@theaquamarine
Force no_entries_ok if rss is run with all_entries=False
81e2265 
RSS can end up producing no entries if all_entries == False. Though
usually handled as-is, if it does not encounter a HTTP 304 response
no_entries_ok is never set.

Fixes Flexget#143
@theaquamarine theaquamarine mentioned this issue Jan 11, 2014
Closed
@theaquamarine
Copy link
Member

Could you tell me what the RSS feed you're using is? Looking at it, I'm pretty it's not giving a http not modified error, which would normally tell flexget that producing no entries is OK. It's an easy fix, but I'd like to test it first.
#145 should fix it, so feel free to try it.

theaquamarine added a commit to theaquamarine/Flexget that referenced this issue Jan 25, 2014
@theaquamarine
Force no_entries_ok if rss is run with all_entries=False
ea55127 
RSS can end up producing no entries if all_entries == False. Though
usually handled as-is, if it does not encounter a HTTP 304 response
no_entries_ok is never set.

Fixes Flexget#143
@ghost
Copy link
Author

ghost commented Jan 26, 2014

Will this ever get merged back into trunk? Do you need to issue a pull request for this to get noticed?

@ghost ghost mentioned this issue Jan 27, 2014
Closed
@theaquamarine
Copy link
Member

Triage & source of problem in #145, particularly #145 (comment).
Problem appears to be task with no_entries_ok fetching feed and output with 0 results being cached. Next task, without no_entries_ok, loads from cache, finds no entries and errors.

@gazpachoking
Copy link
Member

Not a true fix, but I just added an no_entries_ok plugin. You can manually include it in tasks to silence this warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theaquamarine @gazpachoking @stevezau