Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] filelist_api: NameError: name 'valid_extras' #2709

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

rpatterson
Copy link
Contributor

Fixes a crash in the new filelist_api plugin:

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/flexget/task.py", line 535, in __run_plugin
    result = method(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/flexget/event.py", line 22, in __call__
    return self.func(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/flexget/plugins/input/discover.py", line 294, in on_task_input
    return self.execute_searches(config, entries, task)
  File "/usr/lib/python3.8/site-packages/flexget/plugins/input/discover.py", line 134, in execute_searches
    search_results = search.search(task=task, entry=entry, config=plugin_config)
  File "/usr/lib/python3.8/site-packages/flexget/plugin.py", line 127, in wrapped_func
    return func(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/flexget/components/sites/sites/filelist_api.py", line 102, in search
    params.update({extra: 1 for extra in valid_extras if config.get(extra)})
NameError: name 'valid_extras' is not defined

Done through the GitHub UI, so I haven't tested this, but it sure seems like a simple and obvious fix.

Motivation for changes:

Detailed changes:

Addressed issues:

  • Fixes # .

Implemented feature requests:

  • Feathub #XX.

Config usage if relevant (new plugin or updated schema):

paste_config_here

Log and/or tests output (preferably both):

paste output here

To Do:

  • Stuff..

Fixes a crash in the new `filelist_api` plugin:

```
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/flexget/task.py", line 535, in __run_plugin
    result = method(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/flexget/event.py", line 22, in __call__
    return self.func(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/flexget/plugins/input/discover.py", line 294, in on_task_input
    return self.execute_searches(config, entries, task)
  File "/usr/lib/python3.8/site-packages/flexget/plugins/input/discover.py", line 134, in execute_searches
    search_results = search.search(task=task, entry=entry, config=plugin_config)
  File "/usr/lib/python3.8/site-packages/flexget/plugin.py", line 127, in wrapped_func
    return func(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/flexget/components/sites/sites/filelist_api.py", line 102, in search
    params.update({extra: 1 for extra in valid_extras if config.get(extra)})
NameError: name 'valid_extras' is not defined
```

Done through the GitHub UI, so I haven't tested this, but it sure seems like a simple and obvious fix.
@liiight liiight changed the title fix(filelist): NameError: name 'valid_extras' [fix] filelist_api: NameError: name 'valid_extras' Jul 14, 2020
@liiight liiight merged commit babca72 into Flexget:develop Jul 14, 2020
@liiight
Copy link
Member

liiight commented Jul 14, 2020

thanks for this

@rpatterson rpatterson deleted the patch-1 branch July 14, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants