Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [Lostfilm Plugin] Update regex according to new feed version #2912

Merged
merged 1 commit into from
Apr 26, 2021
Merged

[fix] [Lostfilm Plugin] Update regex according to new feed version #2912

merged 1 commit into from
Apr 26, 2021

Conversation

zankevich
Copy link
Contributor

@zankevich zankevich commented Apr 21, 2021

Motivation for changes:

According to changes of rss feed we need to change regex to set poster id properly.

<?xml version="1.0" encoding="utf-8" ?>
<rss version="0.91">
<channel>
<title>LostFilm.TV</title>
<description>Свежачок от LostFilm.TV</description>
<link>https://www.lostfilm.tv/</link>
<lastBuildDate>Wed, 21 Apr 2021 00:34:19 +0000</lastBuildDate>
<language>ru</language><item>
	<title>Город на холме (City on a Hill). Слишком белые и слишком глупые. (S02E04)</title>
	<description><![CDATA[<img src="//static.lostfilm.win/Images/437/Posters/image.jpg" alt="" /><br />]]></description>
	<pubDate>Wed, 21 Apr 2021 00:34:18 +0000</pubDate>
	<link>https://www.lostfilm.win/mr/series/City_on_a_Hill/season_2/episode_4/</link>
</item></channel>
</rss>

Detailed changes:

@GreyKat
Copy link
Contributor

GreyKat commented Apr 21, 2021

I would go with more universal regex:

LOSTFILM_ID_REGEXP = re.compile(r'.*static.lostfilm.[a-z]{2,}/Images/(\d+)/Posters/.*')

@Spider84
Copy link
Contributor

LOSTFILM_ID_REGEXP = re.compile(r'.*static.lostfilm.[a-z]{2,}/Images/(\d+)/Posters/.*')

'.*static\.lostfilm\.[a-z]{2,}/Images/(\d+)/Posters/.*'

@zankevich zankevich mentioned this pull request Apr 23, 2021
@liiight
Copy link
Member

liiight commented Apr 25, 2021

LGTM. Does this work? I can't test this

@Spider84
Copy link
Contributor

LGTM. Does this work? I can't test this
yes

@zankevich zankevich changed the title Update regex according to new feed version [Lostfilm Plugin] Update regex according to new feed version Apr 25, 2021
@liiight liiight changed the title [Lostfilm Plugin] Update regex according to new feed version [fix] [Lostfilm Plugin] Upd ate regex according to new feed version Apr 26, 2021
@liiight liiight merged commit 631723c into Flexget:develop Apr 26, 2021
@liiight
Copy link
Member

liiight commented Apr 26, 2021

Thanks!

@zankevich zankevich changed the title [fix] [Lostfilm Plugin] Upd ate regex according to new feed version [fix] [Lostfilm Plugin] Update regex according to new feed version Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants