New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nzbgeek search plugin #2674
Nzbgeek search plugin #2674
Conversation
Modified version of newznab plugin with minor corrections for compatibility with the nzbgeek api
Instead of a copy-paste, can you refactor so these plugins can share common code? |
This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
Just saw the refactor request. I will take a look at doing so. |
This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
I am not sure I can refactor this without breaking previous functionality. I suppose it could be done by adding optional settings that would only use the modified code when nzbgeek is selected. I will try to make time to review it sometime this week. Frankly, I don't use this anymore, so I will have to setup a new environment for testing. |
This PR is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
This PR has been stale for 60 days and is being closed. Apologies if this is still relevant, it can be hard to find the time to review and merge everything. Feel free to make sure it is up to date and open it again. |
Motivation for changes:
I use nzbgeek for searching and ran into problems using newznab and search_rss.
Detailed changes:
I copied newznab.py and renamed it nzbgeek.py with the following modifications.
Addressed issues:
Fix1. newznab does not retain parameters on re-run. For example apikey, category, extended, and entry parameters are included in the initial request, but only entry parameters are included in re-run requests.
The easiest fix was to add them to the config['url'] variable which is not overwritten on subsequent reruns (line 53).
Fix 2. nzbgeek uses 'imdbid' rather than 'imdb_id' (lines 121 & 122)
Fix 3. I corrected a simple boolean error that affected logging on line 69. Should have been 'if not'
Fix 4. hardcoded nzbgeek domain. Only category and api are required.
Config usage if relevant (new plugin or updated schema):