Fix potential memory/controller leak

FlickType · Jan 1, 2024 · ecbfe9d · ecbfe9d
1 parent 293d21b
commit ecbfe9d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Sources/FlickTypeKit/FlickTypeKit.swift b/Sources/FlickTypeKit/FlickTypeKit.swift
@@ -88,8 +88,9 @@ public extension WKInterfaceController {
   internal func presentSystemInputController(_ invocation: TextInputInvocation) {
 
     let flickTypeText = "⌨︎\tFlickType\n\tKeyboard"
-    func completionWrapper(textInputControllerReturnedItems: [Any]?) {
-      if let inputText = textInputControllerReturnedItems?.first as? String {
+    // Ensure we only hold a weak reference to self here
+    let completionWrapper: ([Any]?) -> Void = { [weak self] textInputControllerReturnedItems in
+      if let self, let inputText = textInputControllerReturnedItems?.first as? String {
         if inputText == flickTypeText {
           return presentFlickTypeOrIntermediateController(invocation)
         }