Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made crafting obey remaining items, and added some non-working recipes. #5

Merged
merged 4 commits into from
Aug 3, 2021

Conversation

avixk
Copy link
Contributor

@avixk avixk commented Aug 1, 2021

I use this fork on my server, and so I added a few things that I wanted. Remaining crafting items (like bottles from crafting honey blocks) are now respected, they will be put into the output container along with the crafted item.

Also firework crafting and shulker dyeing did not work, so I added a few recipes to fix it.

@avixk avixk mentioned this pull request Aug 1, 2021
@MrTransistorsChannel
Copy link
Collaborator

Ok I`ll test your fix tomorrow, seems working to me. Also the recipe for FW rockets with flight duration 1 was added in 1.17 so it can be removed to avoid recipe duplication.

@avixk
Copy link
Contributor Author

avixk commented Aug 2, 2021

Ok I`ll test your fix tomorrow, seems working to me. Also the recipe for FW rockets with flight duration 1 was added in 1.17 so it can be removed to avoid recipe duplication.

"Creative" rockets can be crafted without the added recipes, but flight duration 1 2 and 3 cannot be.

@MrTransistorsChannel
Copy link
Collaborator

Ok I`ll test your fix tomorrow, seems working to me. Also the recipe for FW rockets with flight duration 1 was added in 1.17 so it can be removed to avoid recipe duplication.

"Creative" rockets can be crafted without the added recipes, but flight duration 1 2 and 3 cannot be.

"Creative" rockets are the same as 1 flight duration, just without the nbt. The only problem with this is that they cannot be stacked together, which in my opinion is not a big deal because if a person is going to build a rocket crafter, he probably won`t need to make them manually anymore.
Other solution may be force adding nbt to rockets without it.

I`m not sure about the consequences of a recipe duplication

I will test your fork and see if there are any problems with it.

@avixk
Copy link
Contributor Author

avixk commented Aug 2, 2021

Ok I`ll test your fix tomorrow, seems working to me. Also the recipe for FW rockets with flight duration 1 was added in 1.17 so it can be removed to avoid recipe duplication.

"Creative" rockets can be crafted without the added recipes, but flight duration 1 2 and 3 cannot be.

"Creative" rockets are the same as 1 flight duration, just without the nbt. The only problem with this is that they cannot be stacked together, which in my opinion is not a big deal because if a person is going to build a rocket crafter, he probably won`t need to make them manually anymore.
Other solution may be force adding nbt to rockets without it.

I`m not sure about the consequences of a recipe duplication

I will test your fork and see if there are any problems with it.

Are you sure "creative" and flight duration 1 rockets are the same? I tested it and they seemed slightly worse than flight duration 1.

@MrTransistorsChannel
Copy link
Collaborator

Well, my bad, I always thought they had the same flight durations:)
have just tested and they really are a little bit worse

@MrTransistorsChannel
Copy link
Collaborator

I`m now rewriting your algorithm into the original source code to save the original project structure and fix some other issues (#7)
Will add custom recipes in a separate update.
I have a different view on how to manage dropping items so it also will be in a separate update

@MrTransistorsChannel
Copy link
Collaborator

MrTransistorsChannel commented Aug 3, 2021

Implemented your method in #8, works fine, waiting for @Fliens to rewiew

@Fliens
Copy link
Owner

Fliens commented Aug 3, 2021

Looks good to me

@Fliens Fliens merged commit 44f3e6a into Fliens:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants