-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple strings files #67
Conversation
- Add check for string extraction. - Add check for support via command line actor (currentyly failing).
Apparently, there is a problem. BartyCrouch tries to localize .strings files of storyboard files. I'll look into this. |
- Add test for strings files search.
Hi @mathebox, thank you for this PR. Did you succeed in fixing the issue? Also, could you please update your commit messages to conform to the contribution guidelines? Mainly you need to remove the dot at the end of your commit messages. |
Hi @Dschee. Yes, I fixed the problem. Feel free to use 'merge & squash' for this pull request. |
@mathebox Thank you for this PR, looks good to me and the tests seem to pass as well. Merging this. |
Gonna wait a bit and see if #73 is finished soon and release in a few days at the latest. |
Unfortunately your solution had unexpected side effects. See #11 for more details. |
With this PR, it becomes possible to use multiple strings files in a project when using the
--extract-loc-strings
option. If aNSLocalizedString
call specifies a specific table name, the key will be put in the according file.For example, the usage of
NSLocalizedString("key", tableName: "CustomName", comment: "...")
will require aCustomName.strings
file.Because of this, a
Localizable.strings
file is no longer strictly required. Any other.string
file will also work.Fixes #20
Question:
StringsFilesSearch.findAllStringsFiles(within baseDirectoryPath: String, withFileName fileName: String)
is currently not used. This method might helpful for future functionality. Should I remove this method anyway?