Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keys consisting of only parameters don't have a useful generated code #23

Closed
Jeehut opened this issue Oct 14, 2022 · 2 comments
Closed
Assignees
Labels
Bug Report An unexpected behavior of existing functionality Size: Tiny Probably less than 1 day of work

Comments

@Jeehut
Copy link
Member

Jeehut commented Oct 14, 2022

Steps to Reproduce:

  1. Add the entry "%1$@ %2$@" = "%1$@ %2$@"; to a Strings file
  2. Let ReMafoX generate the enum

Expected Behavior:

I would expect to see some useful naming for the generated code, such as UnnamedParam1UnnamedParam2.

Current Behavior:

The key name is _12, which is not very useful.

Environment

This was reported to me through other channels, no context provided. But current app version on store is 1.0.2.

@Jeehut Jeehut added the Bug Report An unexpected behavior of existing functionality label Oct 14, 2022
@Jeehut Jeehut self-assigned this Oct 14, 2022
@Jeehut Jeehut added the Size: Tiny Probably less than 1 day of work label Oct 14, 2022
@Jeehut Jeehut closed this as completed Oct 15, 2022
@Jeehut
Copy link
Member Author

Jeehut commented Oct 15, 2022

I just implemented this and it will fixed as part of the next release (anything above 1.0.2).

@Jeehut
Copy link
Member Author

Jeehut commented Oct 16, 2022

Just uploaded and submitted version 1.0.3 with the fix for review. Should be available in ~24 h from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report An unexpected behavior of existing functionality Size: Tiny Probably less than 1 day of work
Projects
None yet
Development

No branches or pull requests

1 participant