Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Java 16 support #196

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions framework/inject-primitive/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,5 @@ plugins {
group = "net.flintmc"

dependencies {

api("com.google.inject", "guice", "4.2.0")

api("ca.stellardrift.guice-backport", "guice", "5.0.1")
}
3 changes: 1 addition & 2 deletions framework/stereotype/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ dependencies {
api("net.flintmc.installer", "launcher-plugin", "1.1.12")

api("com.google.guava", "guava", "21.0")
api("com.google.inject", "guice", "4.2.0")
api("ca.stellardrift.guice-backport", "guice", "5.0.1")
api("org.apache.commons", "commons-lang3", "3.9")
api("org.codehaus.groovy", "groovy-all", "3.0.2")
api("org.javassist", "javassist", "3.27.0-GA")

}
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,15 @@
import com.google.inject.Inject;
import com.google.inject.Singleton;
import com.google.inject.name.Named;
import java.io.IOException;
import net.flintmc.framework.packages.PackageClassLoader;
import net.flintmc.framework.stereotype.service.CacheIdRetriever;
import net.flintmc.launcher.classloading.ClassTransformException;
import net.flintmc.launcher.classloading.RootClassLoader;
import net.flintmc.launcher.classloading.common.ClassInformation;
import net.flintmc.launcher.classloading.common.CommonClassLoader;
import net.flintmc.launcher.classloading.common.CommonClassLoaderHelper;
import net.flintmc.transform.asm.ASMUtils;
import net.flintmc.launcher.classloading.ClassTransformException;
import net.flintmc.transform.launchplugin.LateInjectedTransformer;
import net.flintmc.transform.minecraft.MinecraftTransformer;
import net.flintmc.transform.minecraft.obfuscate.remap.MinecraftClassRemapper;
Expand All @@ -39,15 +40,13 @@
import org.objectweb.asm.ClassWriter;
import org.objectweb.asm.commons.ClassRemapper;
import org.objectweb.asm.tree.ClassNode;
import java.io.IOException;

/**
* Deobfuscates all minecraft classes for which mappings are provided
*/
@Singleton
@MinecraftTransformer(priority = Integer.MIN_VALUE)
public class MinecraftInstructionObfuscator implements LateInjectedTransformer,
CacheIdRetriever {
public class MinecraftInstructionObfuscator implements LateInjectedTransformer, CacheIdRetriever {

private final MinecraftClassRemapper minecraftClassRemapper;
private final RootClassLoader rootClassLoader;
Expand All @@ -59,7 +58,8 @@ public class MinecraftInstructionObfuscator implements LateInjectedTransformer,
@Inject
private MinecraftInstructionObfuscator(
MinecraftClassRemapper minecraftClassRemapper,
@Named("obfuscated") boolean obfuscated, ClassCache classCache) {
@Named("obfuscated") boolean obfuscated,
ClassCache classCache) {
this.minecraftClassRemapper = minecraftClassRemapper;
this.classCache = classCache;
this.obfuscated = obfuscated;
Expand All @@ -70,7 +70,7 @@ private MinecraftInstructionObfuscator(
@Override
public byte[] transform(String className, CommonClassLoader classLoader,
byte[] classData) throws ClassTransformException {
if (!obfuscated) {
if (!this.obfuscated) {
return classData;
}
if (!className.startsWith("net.flintmc.")
Expand All @@ -79,7 +79,7 @@ public byte[] transform(String className, CommonClassLoader classLoader,
return classData;
}

final Ref<IOException> exception = new Ref<>();
Ref<IOException> exception = new Ref<>();

byte[] bytecode = this.classCache
.getOrTransformAndWriteClass(className, this.cacheId, classData,
Expand All @@ -101,7 +101,7 @@ public byte[] transform(String className, CommonClassLoader classLoader,
ClassWriter classWriter = new ClassWriter(
ClassWriter.COMPUTE_MAXS);
ClassVisitor classRemapper = new ClassRemapper(classWriter,
minecraftClassRemapper);
this.minecraftClassRemapper);
classNode.accept(classRemapper);
return classWriter.toByteArray();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@

import com.google.inject.Inject;
import com.google.inject.Singleton;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import javassist.ClassPool;
import javassist.CtClass;
import javassist.NotFoundException;
Expand All @@ -37,10 +41,6 @@
import org.objectweb.asm.Type;
import org.objectweb.asm.commons.SimpleRemapper;
import org.objectweb.asm.tree.ClassNode;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* Loads and provides mappings for a {@link org.objectweb.asm.commons.ClassRemapper},
Expand All @@ -54,16 +54,18 @@ public class MinecraftClassRemapper extends SimpleRemapper {
private Handle lastHandle;

@Inject
private MinecraftClassRemapper(ClassPool pool,
private MinecraftClassRemapper(
ClassPool pool,
ClassMappingProvider classMappingProvider) {
super(collectMappings(pool, classMappingProvider));
this.classMappingProvider = classMappingProvider;
assert this.getClass().getClassLoader() instanceof RootClassLoader;
this.rootClassLoader = (RootClassLoader) getClass().getClassLoader();
assert super.getClass().getClassLoader() instanceof RootClassLoader;
this.rootClassLoader = (RootClassLoader) super.getClass().getClassLoader();
this.rootClassLoader.excludeFromModification("org.objectweb.asm.");
}

private static Map<String, String> collectMappings(ClassPool pool,
private static Map<String, String> collectMappings(
ClassPool pool,
ClassMappingProvider classMappingProvider) {
Map<String, String> mappings = new HashMap<>();

Expand Down
2 changes: 1 addition & 1 deletion util/commons/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ group = "net.flintmc"

dependencies {
api("org.joml", "joml", "1.9.25")
api("com.google.inject", "guice", "4.2.0")
api("ca.stellardrift.guice-backport", "guice", "5.0.1")

implementation("com.google.auto.service", "auto-service", "1.0-rc6")
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

package net.flintmc.util.mappings;

import com.google.inject.internal.cglib.core.$RejectModifierPredicate;
import javassist.ClassPool;
import javassist.CtClass;
import javassist.CtMethod;
Expand Down
2 changes: 1 addition & 1 deletion util/unit-testing/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ dependencies {
api(platform("org.junit:junit-bom:5.7.0"))
api("org.junit.jupiter", "junit-jupiter", "5.7.0")
api("org.junit.jupiter", "junit-jupiter-api", "5.7.0")
api("com.google.inject", "guice", "4.2.0")
api("ca.stellardrift.guice-backport", "guice", "5.0.1")
api("org.mockito:mockito-core:3.7.7")
}