LRU for image-cache #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2015 19:41
Least Recently Used Cache for Image Cache
:-|
|
Patched now. (The madness occured because I updated the method tested decided too small removed it at the end and then committed, -- somewhere in b/w forgot i need to make the function direct-- ) |
| }, | ||
|
|
||
| _reduceLeastUsed: function (least, currentHash) { | ||
| var current = this.elements[currentHash]; |
There was a problem hiding this comment.
Can use _instancePool.elements[currentHash] instead of this, and remove the runtime binding in popLeastUsed().
There was a problem hiding this comment.
More nit-picking: 2 space indent instead of 4 :)
|
I like this change. If you could address the minor things I mentioned in comments, and then take a second to fill out the CLA we can merge this into master. |
|
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Least Recently Used Cache for Image Cache