Add a new prop - onEndReachedThresholdRelative #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
requested changes
Mar 9, 2022
src/core/RecyclerListView.tsx
Outdated
| if (windowBound - lastOffset <= Default.value<number>(this.props.onEndReachedThreshold, 0)) { | ||
| const threshold = windowBound - lastOffset | ||
|
|
||
| const triggerOnEndThresholdRelative = windowBound * Default.value<number>(this.props.onEndReachedThresholdRelative, 0); |
There was a problem hiding this comment.
Looks like the bound here refers to maxScrollOffset so this compute can be wrong. Our check needs to be something like threshold <= this._layout.height * relative_threshold
src/core/RecyclerListView.tsx
Outdated
| const threshold = windowBound - lastOffset | ||
|
|
||
| const triggerOnEndThresholdRelative = windowBound * Default.value<number>(this.props.onEndReachedThresholdRelative, 0); | ||
| const triggerOnEndThreshold = windowBound * Default.value<number>(this.props.onEndReachedThreshold, 0); |
There was a problem hiding this comment.
This multiplication is not needed
naqvitalha
reviewed
Mar 9, 2022
README.md
Outdated
| @@ -90,6 +90,7 @@ In case you cannot determine heights of items in advance just set `forceNonDeter | |||
| | externalScrollView | No | { new (props: ScrollViewDefaultProps): BaseScrollView } | Use this to pass your on implementation of BaseScrollView | | |||
| | onEndReached | No | () => void | Callback function executed when the end of the view is hit (minus onEndThreshold if defined) | | |||
| | onEndReachedThreshold | No | number | Specify how many pixels in advance for the onEndReached callback | | |||
| | onEndReachedThresholdRelative | No | number | Specify the percent of a view in advance for the onEndReached callback | | |||
There was a problem hiding this comment.
Rephrase this IMO. It's a little difficult to understand right now.
|
@ElviraBurchik you will need to look into the lint issues. CI checks are failing |
- Update new prop description in readme
|
@naqvitalha I've addressed your comments and fix lint issues, but looks like I can't re-run CI check myself. |
naqvitalha
approved these changes
Mar 10, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new prop
onEndReachedThresholdRelativeidentical to theonEndReachedThresholdof FlatList.It allows to specify how far from the end (in units of visible length of the list) the bottom edge of the list must be from the end of the content to trigger the onEndReached callback