Edit data source button now disappears when user switches back to placeholder #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squallstar
approved these changes
May 6, 2020
There was a problem hiding this comment.
@sofiiakvasnevska this is ready to be deployed on staging for QA.
- Risk: Low
- Affected: Studio users configuring the component
- Verify: Verify the issue is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
Issue
https://github.com/Fliplet/fliplet-studio/issues/5662
Description
I found that this issue reproduces also for email and SMS verification components.
When the user switches back to 'Select a data source' placeholder value it passes to the data source query is null as a string.
Screenshots/screencasts
https://streamable.com/0yvrpz
Reviewers
@upplabs-alex-levchenko @YaroslavOvdii
Backward compatibility
This change is fully backward compatible.