Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Radar Scanner, BarcodeGen, New Terminal Menu #415

Merged
merged 8 commits into from
Oct 15, 2023
Merged

Updated Radar Scanner, BarcodeGen, New Terminal Menu #415

merged 8 commits into from
Oct 15, 2023

Conversation

MatthewKuKanich
Copy link
Collaborator

What's new

  • Reworked the interface to be easier to use/see

  • Modified the logic to accept input from pin 2 and set an alternate ground to pin 3

  • This allows for anyone to use the app with just the radar unit, no need to build a module

  • Alternate pinout is toggle-able via right button press

  • Added auto 5v on launch feature, thanks willy! :)

  • Reworked a couple functions to be cleaner


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL
Copy link
Contributor

Willy-JL commented Oct 10, 2023

that 5v power attempt snippet actually is by @xMasterX :D

also we are moving all apps to https://github.com/Flipper-XFW/Xtreme-Apps, hadn't gotten to this app yet so its fine that you PR'd this here :)

Copy link
Contributor

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MatthewKuKanich
Copy link
Collaborator Author

that 5v power attempt snippet actually is by @xMasterX :D

also we are moving all apps to Flipper-XFW/Xtreme-Apps, hadn't gotten to this app yet so its fine that you PR'd this here :)

Gotcha, thanks for letting me know! I was told it was you, so wanted to make sure I gave credit. I'll do future app PRs there when the transition is ready. You should give the app a try now that it's more accessible! $5-10 for a 5 pack of radar units

@Willy-JL
Copy link
Contributor

nice! also hopefully wont need to send update PRs, the point of the new repo is automated updates right from the original repository with git bulk-update-apps, our own secret sauce

@MatthewKuKanich MatthewKuKanich changed the title Updated Radar Scanner (altpinout + many updates) Updated Radar Scanner, BarcodeGen, New Terminal Menu Oct 11, 2023
@Willy-JL
Copy link
Contributor

pulled the barcode changes from upstream in the apps repo, thanks for backporting for now tho.

menu input code looks fine, but forgot about updating vertical_offset. since this has same input as list and other similar menus, ill move it there and reuse that code. also simplified the drawing code a little.

am yet to flash, will do when im back home. looks fine tho!

@Willy-JL Willy-JL merged commit 3037e8b into Flipper-XFW:dev Oct 15, 2023
3 of 4 checks passed
@Willy-JL Willy-JL added the enhancement New feature or request label Dec 2, 2023
@Willy-JL Willy-JL mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants