Bugfix/38 404 nonexistent cdnjs files #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlipperPA
reviewed
Jun 4, 2023
| f"""<link href="{PRISM_PREFIX}{PRISM_VERSION}/plugins/copy-to-clipboard/""" | ||
| """prism-copy-to-clipboard.min.css" rel="stylesheet">""" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Since we're removing this, we may be able to remove the function from the import, and the settings file. I'll check in depth on Monday. Thanks so much for the PR!
There was a problem hiding this comment.
We only removed the CSS for it since there isn't one for it on CDNJS and was causing the 404. But the JS functionality still works and probably for that reason we would want to keep the function. My pleasure, and thank you for putting this out there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38