Reduce block JS complexity #45
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently bumped into issues that look like #34. It looks like the dynamic loading of the JS libraries for specific languages seems to be the issue, although I couldn't quite find a way to reproduce the issue reliably though to properly track it down.
One thing though that does seem to reliably fix the issue, is switching to using
prism-corein combination with theprism-autoloaderas per the prism docs.Fundamentally, this PR strips out most of that dynamic JS (not in the admin) and replaces with an onus to manually place a couple of template tags in the head and body of the HTML that would be using
wagtailcodeblock. I don't personally see this as a large issue, seems standard behaviour from many other Django Applications.I'm curious to get some input in making a change like this? I'm happy to work on making it backwards compatible so as not to break existing usage. Or something can perhaps be done with the versioning. Open to any thoughts on this.
Apologies if there's a better way to put this forward, I couldn't find any docs on contributing.