Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
EPNW-Eric committed May 12, 2023
1 parent 201e7e4 commit cd52548
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
sdk: '>=2.19.5 <3.0.0'
sdk: '>=2.19.5 <4.0.0'

dependencies:
flutter:
Expand Down
7 changes: 4 additions & 3 deletions lib/src/traceable_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class TraceableWidget extends StatefulWidget {
required this.child,
this.actionName,
this.pvId,
this.updatePvIdAfterPop = true,
this.updatePvIdAfterPop,
this.path,
this.dimensions,
this.campaign,
Expand All @@ -23,7 +23,7 @@ class TraceableWidget extends StatefulWidget {
final String? pvId;

/// {@macro traceableClientMixin.updatePvIdAfterPop}
final bool updatePvIdAfterPop;
final bool? updatePvIdAfterPop;

/// {@macro traceableClientMixin.path}
final String? path;
Expand Down Expand Up @@ -57,7 +57,8 @@ class _TraceableWidgetState extends State<TraceableWidget>
String get pvId => widget.pvId ?? super.pvId;

@override
bool get updatePvIdAfterPop => widget.updatePvIdAfterPop;
bool get updatePvIdAfterPop =>
widget.updatePvIdAfterPop ?? super.updatePvIdAfterPop;

@override
String? get path => widget.path;
Expand Down

0 comments on commit cd52548

Please sign in to comment.