Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] [#129] #130

Merged
merged 1 commit into from Dec 29, 2023
Merged

[FEAT] [#129] #130

merged 1 commit into from Dec 29, 2023

Conversation

jainhitesh9998
Copy link
Contributor

Changed type of siteId to String

@jainhitesh9998
[FEAT] [Floating-Dartists#129]
2156655 
Changed type of siteId to String
@TesteurManiak
Copy link
Member

Fix #129

TesteurManiak
TesteurManiak approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Considering that it is a breaking change of the API it will have to wait v5 of the package before being published on pub.dev

@TesteurManiak TesteurManiak merged commit e797d11 into Floating-Dartists:main Dec 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TesteurManiak TesteurManiak TesteurManiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jainhitesh9998 @TesteurManiak