-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection as an object #1085
Collection as an object #1085
Conversation
This is probably a "next PR" type thing, but being able to choose the preview model (in the same way you can choose a preview file for a model) would be awesome. |
…ctions, add default for collection pagination in user_settings in db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of code tweak suggestions to tidy things up a bit more.
Co-authored-by: James Smith <james@floppy.org.uk>
Co-authored-by: James Smith <james@floppy.org.uk>
Co-authored-by: James Smith <james@floppy.org.uk>
Co-authored-by: James Smith <james@floppy.org.uk>
Co-authored-by: James Smith <james@floppy.org.uk>
Code Climate has analyzed commit 6bf4699 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 53.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.1% (-0.1% change). View more on Code Climate. |
This isn't ready yet... just starting a draft for discussion