Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to autoload preview only up to a set size, then click to load #1335

Merged
merged 11 commits into from
Jul 10, 2023

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Jul 10, 2023

Resolves #909

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<div class="progress position-absolute top-50 start-50 translate-middle">
<div class="progress-bar" role="progressbar" style="width: 0%;" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100">0%</div>
<div class="load-progress progress position-absolute top-50 start-50 translate-middle" style="height: 3em; z-index: 2; cursor: pointer">
<div class="progress-bar bg-info progress-bar-animated progress-bar-striped" role="progressbar" style="width: 0%;" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good bot

@Floppy Floppy added the feature User-facing features and product enhancements label Jul 10, 2023
@Floppy Floppy marked this pull request as ready for review July 10, 2023 16:00
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit d6ea041 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.8% (0.0% change).

View more on Code Climate.

@Floppy Floppy merged commit 49abcf6 into main Jul 10, 2023
11 checks passed
@Floppy Floppy deleted the click-to-load branch July 10, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to not auto-load in renderer
1 participant