Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about rewriting @? #1

Closed
littleggghost opened this issue May 27, 2019 · 2 comments
Closed

How about rewriting @? #1

littleggghost opened this issue May 27, 2019 · 2 comments

Comments

@littleggghost
Copy link
Contributor

littleggghost commented May 27, 2019

Hi, @FlorianWilk
You did a really awesome job! I can't believe that you can model a Spot-like robot and get an nice achievement in control!
There maybe has a "problem": It would be better if this code could support python2.7 and python3 simultaneously. But the grammar "@" in kinematics.py seems not supported in py2.7 which just means matrix multiplication. So, maybe replace the "@" by normal grammar is better? Or wait for my PR?

Best Regards!

@FlorianWilk
Copy link
Owner

FlorianWilk commented May 27, 2019 via email

@littleggghost
Copy link
Contributor Author

Thanks for your reply!
I will commit a PR to make it compatible with py2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants