Make the ModalBarrier not dismissible when barrierEnabled is true #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #5
The
ModalBarrier
that is shown whenbarrierEnabled
is true has adismissible
value that defaults totrue
. This means theModalBarrier
can still be dismissed even though the barrier is enabled.Approach 1: This PR sets the
dismissible
value to false so theModalBarrier
cannot be dismissed.Approach 2:
If it is the intention of the author to leave
dismissible
astrue
, another way to solve the issue is to make the following change:Approach 1 seems preferable because it is slightly counter-intuitive if the
ModalBarrier
can be dismissed even thoughbarrierEnabled
istrue
.