Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Majavi #280

Open
buhlaze opened this issue Jun 5, 2018 · 200 comments
Open

Doesn't work on Majavi #280

buhlaze opened this issue Jun 5, 2018 · 200 comments

Comments

@buhlaze
Copy link

buhlaze commented Jun 5, 2018

Can we get a patch for Mojavi 10.14? I tried the current one and it does not work.

@Floris497
Copy link
Owner

Just got it installed, will check it out later this week maybe next week, since I have some holidays now :)

@Floris497
Copy link
Owner

Floris497 commented Jun 5, 2018

Highly risky

not tested at al, did not even check if my Mac still boots.. but for the sake of it..

EDIT: New file..
CoreDisplay-patcher.command.zip

@Floris497
Copy link
Owner

It does boot.. that's something.. only "SwitchResX" has a bug and can't make custom res.. so maybe it does work maybe it does not.. feel free to share if it worked or not :)
(I'm still not responsible if you system doesn't boot after)

@scottsanett
Copy link

It doesn't seem to be working on my Hackintosh, i.e. unable to use 4K monitor with non-iris integrated graphics.

@Floris497
Copy link
Owner

Did you make custom resolutions?

@scottsanett
Copy link

scottsanett commented Jun 5, 2018

It's a newly installed Mojave beta so I don't think so.


Hmmm, I disassembled both the patched and unpatched CoreDisplay and it doesn't seem that there is any difference at all.

@Floris497
Copy link
Owner

Oh.. well.. could have been i was tired.. didn't check uh... I'll try again

@Floris497
Copy link
Owner

I made a small mistake with the copy paste, new file attached to the comment :) should patch and boot.. if it works.. idk

@phamminhtris
Copy link

Well, I have tested your new file. It does not seem to work.

@golimpio
Copy link

Have anyone managed to make it work with Mojave?

@simnsdt
Copy link

simnsdt commented Jul 31, 2018

Any updates on this? Gonna try it myself soon on Mojave.

@danieltroger
Copy link

Tried it on mojave (10.14 Beta, Build 18A371a). Doesn't work.
You forgot adding v5 to the list of commands at

    fi
    case "$2" in
      v1) CoreDisplayPatch 1;;
      v2) CoreDisplayPatch 2;;
	  v3) CoreDisplayPatch 3;;
	  v4) CoreDisplayPatch 4;;

But even after adding and rebooting it doesn't work.
Btw, here's the beta version of SwitchResX that support Mojave, in case somebody is looking for it: https://www.madrau.com/SwitchResXb.zip

I'd love if you could do a patch, here's my version of CoreDisplay: https://mega.nz/#!ATRDBSZB!3gfsvTLVyVJaB0Qx2pSWwFHQqzIcy05V9xzqv_uN4ig

@Floris497
Copy link
Owner

Not much active on the project lately, but I’ll try some stuff somewhere around this week :)

@ihainan
Copy link

ihainan commented Sep 9, 2018

@Floris497 Just curious if any progress has been made on this issue? :D

@Floris497
Copy link
Owner

Not really.. turns out I have no hardware available anymore to test this on.. I have an 2011 MacMini.. but unfortunately it does not run Mojave.. my 2013 MacBook Air does not support 4k at all (some frame buffer problem.. I'll give that a look again actually) right now I'm going to test some stuff to see what I can get working.. but don't expect to much soon.. (a well maybe I have something today, who knows)

@Floris497
Copy link
Owner

Uh.. it looks like the whole code is rewritten.. (maybe in swift.. I don't know enough about what the asm that swift produces looks like..) anyway.. I'm not here the next 2 days.. (just few hours today) if I don't get anything now.. it's gonna take some days.. anyone interested to break their system once I find something that MAYBE works? :D

@danieltroger
Copy link

danieltroger commented Sep 11, 2018 via email

@Floris497
Copy link
Owner

Floris497 commented Sep 12, 2018

Yes, if it does not work you can easily restore the old one. but just don't be scared of single user mode :) (I tried to patch 2 things.. both don't seem to work..)

@Floris497
Copy link
Owner

Guys.. maybe I found something.. feel free to test it.. it does not crash my system, so it should be fairly safe.. but the big question.. does it work. please let me know what it does :)
CoreDisplay-patcher.command.zip

@gujiangjiang
Copy link

@Floris497 WORKS!
qq20180916-000856 2x

You are so quickly to find the new patch and it works perfectly!

Thanks very much!

@ro7in
Copy link

ro7in commented Sep 15, 2018

@Floris497 WORKS!
qq20180916-000856 2x

You are so quickly to find the new patch and it works perfectly!

Thanks very much!
I don't know about you, but mine still does not work.

screen shot 2018-09-15 at 1 53 02 pm

@Floris497
Copy link
Owner

Floris497 commented Sep 15, 2018

WHAT?!? It works??? Yusss!
Oh I guess I cheered too early.. anyway I’m not home till tomorrow..

@ro7in
Copy link

ro7in commented Sep 15, 2018

I have no idea if it's really work on his machine, but it doesn't work on mine.

@benbaker76
Copy link

benbaker76 commented Sep 15, 2018

I'm using WhateverGreen cdf patch and it appears to work fine for me in macOS (18A389)

CoreDisplay-patcher.command:
Find: 4D 8B 36 4D 85 F6 0F 85 29 FD FF FF 31 DB EB 47 Replace: 4D 8B 36 48 85 C0 0F 84 29 FD FF FF 31 DB EB 47

WhateverGreen cdf:
Find: BB 01 00 00 00 A8 01 0F 85 Replace: 31 DB 90 90 90 90 90 90 E9

Why are the two patches so different?

EDIT: I think gujiangjiang is also using WEG cdf patch so he probably just needed to reboot a few times for it to start working (I have to do this after an update).

@gujiangjiang
Copy link

@headkaze WEG -cdfon was no use on macOS 10.14 i have tested.

How you use WEG -cdfon to use cdfpatch?

-cdfon or enable-hdmi20?

@Floris497
Copy link
Owner

Oh.. now I’m confused.. so the old patch is still working on hack? It isn’t on native mac... I kinda lost what is going on with it anyhow..

@gujiangjiang
Copy link

I use old patch with CDF or WEG are all not work and i dont know how to use it.

@Floris497
Copy link
Owner

Right.. so there is nothing to do? I’m going to have a look at what is going om exactly tomorrow 🙃

@gujiangjiang
Copy link

now it works fine with your new patch.
but WEG still with no use and i dont know what happend and i tried -cdfon and enable-hdmi20 but both with no use.
Maybe it is Lilu related problem?

@cyberfunk
Copy link

Darn it! All of my backups are 10.14.2. Can you upload your Coredisplay file or if I can find the Mojave 10.14.0 or 10.14.1 installer can I extract it?

@Floris497
Copy link
Owner

Drag and drop, find the location of file in top of patcher file. Make sure to make backup from backup since it will be the original file.. if you keep it there it will be overwriten by the patch when patching the transplanted CoreDisplay. If it makes sense?

@cyberfunk
Copy link

cyberfunk commented Dec 17, 2018

It makes sense but I don't have access to 10.14.1. All of my backups are 10.14.2. Do you know where I can find CoreDisplay file for 10.14.0 or 10.14.1?

@Floris497
Copy link
Owner

Ah, You use WhateverGreen.. so there will not be a backup file.. so Backup oroginal CoreDisplay file.. (duplicate then rename like CoreDisplay.bk or something) and make whatevergreen force the patch, i think it can do so.

@cyberfunk
Copy link

I'm going to try to find a 10.14.0 or 10.14.1 full installer and do a fresh install.

@cyberfunk
Copy link

OK I found a 10.14.1 full installer and downloading now. You really think your patch will work with 10.14.1?

@Floris497
Copy link
Owner

Not 100% sure.. but it might be worth a try? If everything fails you can just go back to High Sierra.. depends on the time you want to spend

@cyberfunk
Copy link

Dark mode is worth the time! Anything to avoid that blinding Apple blue and gray GUI🤣

@devianter
Copy link

Dark mode is not worth it. If the UI blinds you, you need to lower the brightness, and possibly use night shift, because it’s perfectly fine. It’s been fine for more than 10 years :)
Other than that it’s not like Mojave has a lot of cool stuff. Apart from the new screenshot mechanism everything else is .... not much?...

@Floris497
Copy link
Owner

I do kinda agree, never really used any dark mode.. even PS i opted to light mode.

@devianter
Copy link

Night mode in word and outlook for example looks ridiculous because only the UI is dark, the actual window of emails and background is white. Useless

@cyberfunk
Copy link

cyberfunk commented Dec 17, 2018

Man to each

Dark mode is not worth it. If the UI blinds you, you need to lower the brightness, and possibly use night shift, because it’s perfectly fine. It’s been fine for more than 10 years :)
Other than that it’s not like Mojave has a lot of cool stuff. Apart from the new screenshot mechanism everything else is .... not much?...

To each his own. I'm going to take this to the extreme but just because something's been in place for a "long" time doesn't make it great or even good. I live in the U.S. and we had some pretty crappy policies in place one of them for 400 years that were not great. I used to use software by a company called Avid that was 32 bit for years. It took them forever to update that sucker to 64 bit and many people (including myself) hated the limits imposed by the crappy 32 bit. We knew it was bad for a long time. People have been clamoring for a true dark mode in OS X, now macOS, for a long time citing the comfortable and uniform look of Ubuntu and also the adoption of products like Photoshop, Final Cut Pro and others of an easy on the eyes dark GUI. Now that I have it I don't want to live without it if I don't have to. Just take a look at that screen shot. Look at Finder with the dark folders. I'm in heaven:-)

screen shot 2018-12-17 at 1 24 26 pm

@danieltroger
Copy link

danieltroger commented Dec 17, 2018

@cyberfunk Oh damn, sorry man. Did you try the switchresx daemon?
screen shot 2018-12-17 at 22 27 35
Also I think that if you wanna add the resolution manually you'll have to add a 5120*2880 resolution and then another, second scaled resolution to 2560*1440

@cyberfunk
Copy link

cyberfunk commented Dec 17, 2018

@danieltroger Are you on a 4K monitor 5k or a 1440p monitor? Also are you on 10.14.2? What graphics card are you running? SwitchresX will not accept a custom resolution of 5120x2880 it says invalid if I try to do that. It also basically says invalid if I try to enter 4k as a resolution. It's this bug in Mojave 10.14.2 with Intel HD 520 graphics that defeats all fixes. Can you give full details on your graphics and macOS version? When I ran Mojave 10.14.2 on my older EliteBook with Intel HD 5500 this was not an issue at all so I think it's specifically related to Intel HD 520 and other systems might not be affected in this specific way.

@cyberfunk
Copy link

@danieltroger from your photo it looks like you're on a 5K monitor which would make 1440p a natural resolution for you since it's exactly half of full 5K resolution. For me on 4k monitor 1080p is exactly half of 4K which is why I have no issues seeing that resolution. It's the special (for my setup) 1440p that is not enabled for whatever reason with Intel HD 520 and 4K monitor.

@cyberfunk
Copy link

10.14.1 was a bust. It did patch but nothing changed with graphics resolutions becoming available. I'm just going to suck it up for the time being and accept a 99.9% Golden build. Thanks to everyone for your suggestions and assistance. Happy holidays!

@danieltroger
Copy link

I'm on 10.13.6 on a hackintosh with a GTX 1080ti and a LG 27UD69-W 3840*2160 monitor.
So probably as far away from your config as I could be. Still, the daemon could've shown options otherwise not present, even on Mojave, I suppose?
Good luck with high sierra! I'm also forced to stay because of nvidia not releasing drivers for Mojave.

@cyberfunk
Copy link

Thanks Daniel. I'm not even going to try High Sierra. Something tells me I'll see the same results. This problem is specific to Intel HD 520 Graphics and the way they interact with macOS I think. I don't think anybody else in this thread is running Intel HD 520 so it's tough to corroborate my experience.

@cyberfunk
Copy link

I found an old bootable backup external drive with El Capitan installed and I booted that. Sure enough it has the same problem with the graphics missing 1440p retina option so it's got to be down to Intel HD 520 igpu. I did not have this graphics issue with older Intel HD 5500 on any version of macOS with my old Hackintosh 850 G2. I thought I was upgrading moving to the newer G3 🤣 Guess not...

@cyberfunk
Copy link

cyberfunk commented Dec 28, 2018

Checking back in with an update. I solved all my issues by changing my ig-platform-id from 0x19160000 to 0x19160002. Basically I didn't need any patches or hacks beyond that. Those are the two ID's specified for Intel HD 520 Graphics. That brought all of the standard resolutions back. Unfortunately using 0x19160002 disables wake from sleep for the internal display. Two steps forward one step back. Just a heads up to anyone with my particular setup who needs to unlock 1440p HiDPI for external displays on an EliteBook 850 G3 Hackintosh with Intel HD 520 Graphics:-)

@qvt
Copy link
Contributor

qvt commented Jan 4, 2019

Hey all, the previously suggested patch also worked for me as usual on my Mac mini (Late 2012) with macOS 10.14.2 and my Samsung U28E590 monitor. I am using a Club3D CAC-1153 DisplayPort to HDMI adapter and no extra software. 30Hz as usual.

Excerpt from my system stats:

System Software Overview:
  System Version:	macOS 10.14.2 (18C54)
  Kernel Version:	Darwin 18.2.0
Intel HD Graphics 4000:
  Chipset Model:	Intel HD Graphics 4000
  Type:	GPU
  Bus:	Built-In
  VRAM (Dynamic, Max):	1536 MB
  Vendor:	Intel
  Device ID:	0x0166
  Revision ID:	0x0009
  Metal:	Supported, feature set macOS GPUFamily1 v4
Displays:
U28E590:
  Resolution:	3840x2160 (2160p 4K UHD - Ultra High Definition)
  UI Looks like:	3840 x 2160 @ 30 Hz
  Framebuffer Depth:	24-Bit Colour (ARGB8888)
  Display Serial Number:	HTPG700137  
  Main Display:	Yes
  Connection Type:	DVI or HDMI
  Adapter Firmware Version:	 b.1d

Edit: I see that this patch works for many of us, so I created pull request #297 - @Floris497, feel free to reject this in case there are further complaints :)

qvt pushed a commit to qvt/mac-pixel-clock-patch-V2 that referenced this issue Jan 4, 2019
qvt pushed a commit to qvt/mac-pixel-clock-patch-V2 that referenced this issue Jan 4, 2019
@push108
Copy link

push108 commented May 15, 2019

I just tried updating to 10.14.5, and can report that the existing patch seems to work fine for me: Late 2012 Mac mini, Intel HD Graphics 4000. The MD5 checksum has changed, of course, but patch 5 does work.

@crazyderpygamer
Copy link

I just tried updating to 10.14.5, and can report that the existing patch seems to work fine for me: Late 2012 Mac mini, Intel HD Graphics 4000. The MD5 checksum has changed, of course, but patch 5 does work.

Is patch five just the normal one? Can you provide a download link or anything that can help, as im on 10.14.5 and unable to get my LG 29" 2560x1080. Help is appreciated.

@crazyderpygamer
Copy link

I just tried updating to 10.14.5, and can report that the existing patch seems to work fine for me: Late 2012 Mac mini, Intel HD Graphics 4000. The MD5 checksum has changed, of course, but patch 5 does work.
What or how did you check the MD5 checksum to?

@push108
Copy link

push108 commented May 17, 2019

@crazyderpygamer: Just the normal patch.

You can select patch 5 by running CoreDisplay-patcher.command patch 5.

You can see the MD5 checksums by running CoreDisplay-patcher.command md5:

~/Downloads/mac-pixel-clock-patch-V2-master> ./CoreDisplay-patcher.command md5
---- BEGINNING MD5 HASH SUMS ---- version: 10.14.5 build:18F132

     otool CoreDisplay: 72f042e49f26240c9a7ae6d79d057fb7
 otool CoreDisplay.bak: 814fe7a8695f6583d821b5665f6df71a
           CoreDisplay: 448a6ba839f8877d693dea6fd4f5f09d
       CoreDisplay.bak: 9581c3d50658882e79325bcf5f510245

---- ENDING MD5 HASH SUMS -------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests