Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Element example in README #15

Closed
wants to merge 1 commit into from
Closed

Improve Element example in README #15

wants to merge 1 commit into from

Conversation

penberg
Copy link

@penberg penberg commented Aug 20, 2015

This improves the Element example in README by adding pointers for get_child()
and get_attribute().

This improves the Element example in README by adding pointers for get_child()
and get_attribute().
@flosse
Copy link

flosse commented Aug 21, 2015

thx :)

@penberg
Copy link
Author

penberg commented Aug 25, 2015

@Florob ping

@Florob
Copy link
Owner

Florob commented Aug 25, 2015

pong.
Sorry, not ignoring you I was just preoccupied with FrOSCon. Thank you for the patch.
I'm not quite happy with this though. Blindly unwraping Options is an anti-pattern IMHO, and I try to avoid it, even in documentation. If you'd instead use Option::and_then() and Option::expect(), to get to the href, or make href and Option<&str>, I'll gladly merge this.

@penberg penberg closed this Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants