Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Open Result Modifier Key changes behaviour of Explorer plugin #2191

Closed
2 tasks done
JamesNZL opened this issue Jun 18, 2023 · 5 comments · Fixed by #2432
Closed
2 tasks done

BUG: Open Result Modifier Key changes behaviour of Explorer plugin #2191

JamesNZL opened this issue Jun 18, 2023 · 5 comments · Fixed by #2432
Labels
bug Something isn't working keep-fresh

Comments

@JamesNZL
Copy link
Contributor

JamesNZL commented Jun 18, 2023

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

With Open Result Modifier Key set to Alt

Alt+2 will open the file.

To me, this makes the most sense—I want to quickly open the file I've just searched for.

With Open Result Modifier Key set to Ctrl

Ctrl+2 will open the file in explorer.

This is different behaviour, and not what I'm after.

To Reproduce

  1. Set Open Result Modifier Key to Alt
  2. Use result modifier key to open a file with the Explorer plugin
  3. Set Open Result Modifier Key to Ctrl
  4. Use result modifier key to open a file with the Explorer plugin

    A different behaviour is observed.

Screenshots

With Open Result Modifier Key set to Alt

Alt+1 will open the file.

image
image

With Open Result Modifier Key set to Ctrl

Ctrl+1 will open the file in explorer.

image
image

Flow Launcher Version

1.15.0

Windows Build Number

10.0.22621.1848

Error Log

Replace this line with the important log contents.
@JamesNZL JamesNZL added the bug Something isn't working label Jun 18, 2023
@taooceros
Copy link
Member

I think this is because ctrl + enter will open the result differently, and it is only detected by whether ctrl is pressed. @Flow-Launcher/team should we make the special key behavior avaliable to enter only?

@VictoriousRaptor
Copy link
Contributor

VictoriousRaptor commented Jun 19, 2023

I think this is because ctrl + enter will open the result differently, and it is only detected by whether ctrl is pressed. @Flow-Launcher/team should we make the special key behavior avaliable to enter only?

of course. And what about special key + mouse click?

btw: sorry about accidentally touching the close with comment button

@jjw24
Copy link
Member

jjw24 commented Jul 2, 2023

of course. And what about special key + mouse click?

Should act the same as special key + enter.

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 17, 2023
@github-actions
Copy link

This issue was closed because it has been stale for 7 days with no activity. If you feel this issue still needs attention please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keep-fresh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants