Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Terminal to shell plugin settings #2045

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

add Terminal to shell plugin settings #2045

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a97ea7
add Terminal to shell pulgin settings
ThinkSalat Apr 11, 2023
416e48d
Add Terminal to menu entries
ThinkSalat Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions Plugins/Flow.Launcher.Plugin.Shell/Main.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,22 @@ private ProcessStartInfo PrepareProcessStartInfo(string command, bool runAsAdmin
}
break;
}

case Shell.Terminal:
{
info.FileName = "wt.exe";
if (_settings.LeaveShellOpen)
{
info.ArgumentList.Add("-NoExit");
info.ArgumentList.Add(command);
}
else
{
info.ArgumentList.Add("-Command");
info.ArgumentList.Add(command);
}
break;
}

case Shell.RunCommand:
{
Expand Down
1 change: 1 addition & 0 deletions Plugins/Flow.Launcher.Plugin.Shell/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public enum Shell
Cmd = 0,
Powershell = 1,
RunCommand = 2,
Terminal = 3,
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Would it make sense for this to be named Windows Terminal ?
  2. Do we need translations for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just called Terminal, and flow launcher is windows only, so I don't think the distinction is necessary. As for translations, the other options aren't translated, so it kind of be adding too much responsibility to this PR.


}
}