Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artefact hash discrepancy for WinGet release #2218

Closed
wants to merge 1 commit into from

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Jul 4, 2023

Context:
Currently project is rebuilt and output artefacts re-uploaded after marking a draft release as latest. This creates a discrepancy for WinGet publish process. #2086

Solution:
Tag is created after marking a draft release as prerelease or latest. No need to upload the artefacts again on tag.

If changes need to occurr during release process, delete draft then merge new changes in.

Related #2185

@jjw24 jjw24 added bug Something isn't working CI/CD labels Jul 4, 2023
@jjw24 jjw24 added this to the 1.16.0 milestone Jul 4, 2023
@jjw24 jjw24 requested a review from JohnTheGr8 July 4, 2023 03:32
@jjw24 jjw24 self-assigned this Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

occurr

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the fix_release_dup_hash branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5450537806/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 changed the title Fix duplicate artefact hash on release Fix artefact hash discrepancy for WinGet release Jul 4, 2023
@JohnTheGr8
Copy link
Member

I'm quite sure the first Github deployment job will still run on tag CI builds and update the artifacts of the release. Therefore this does not solve the Winget issue...

See for example this CI job for tag v1.15.0

If you see the very end of the log, it is updating the existing v1.15.0 release artifacts on github, twice.

@JohnTheGr8
Copy link
Member

Perhaps a simpler temporary solution would be to switch the winget release action to manual only? And trigger it manually when both appveyor jobs have finished...

@jjw24
Copy link
Member Author

jjw24 commented Jul 4, 2023

Ah yes, does look like the case.

Yes lets change the WinGet action to manual temporarily.

@jjw24 jjw24 closed this Jul 4, 2023
@jjw24 jjw24 deleted the fix_release_dup_hash branch July 4, 2023 12:08
@jjw24 jjw24 removed this from the 1.16.0 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants