Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2553. Nodejs plugins currently aren't working. The reason is always the same: it throws an index out of bounds exception on line 31.
![Error screenshot 1 (npm)](https://private-user-images.githubusercontent.com/3993179/303841167-cb268c7c-8aa3-4016-a284-b5fcd257563f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTE2Ny1jYjI2OGM3Yy04YWEzLTQwMTYtYTI4NC1iNWZjZDI1NzU2M2YucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWZmYjMwOGQ0MTBlODY0MWE4M2ViMTlkOWM2YjA5OTcxNjE2N2Q2M2QyNDIwMjk1OGZiMzg1NTY4MzA1NmJiZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.b5BiemRo7JaPSJ0QpIsn-ZkA_KMjudLAbF6QqTGyRRs)
![Error screenshot 2 (mdn)](https://private-user-images.githubusercontent.com/3993179/303841168-67f606a0-2ae8-48f1-8ea4-7c8ce524b4b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTE2OC02N2Y2MDZhMC0yYWU4LTQ4ZjEtOGVhNC03YzhjZTUyNGI0YjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWNjNGQyOWE2OWRiNGVhMDc2MmQwYzA2NTM0YjZmMDJlMjZhZjEzMmFkYWJhMWZkY2Q3MjZhNzQ2MzY4NzQ2YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ehIVrwCDHICt857pUIigxnq5pJV45nl1Sy0f3KZtY0A)
![Error screenshot 3 (beat)](https://private-user-images.githubusercontent.com/3993179/303841170-87a9f530-751d-4e9b-b68e-c39373fab2e6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTE3MC04N2E5ZjUzMC03NTFkLTRlOWItYjY4ZS1jMzkzNzNmYWIyZTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTU5NDlkNzU1YmYzYjcwY2MzZjkwNTE5MmY5YTQ1YmJlZWVmYjdjMTg5NTY1ZTcwOTA4N2RhNjBhNGM4NDdlNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.JjtStyHfzszI2qohIJ2dlJjaYnvs9q8lRBtp0DfWLJ0)
![Error screenshot 4 (hn)](https://private-user-images.githubusercontent.com/3993179/303841171-0a0f0ca4-b845-41b0-a7bb-258f29c9a989.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTE3MS0wYTBmMGNhNC1iODQ1LTQxYjAtYTdiYi0yNThmMjljOWE5ODkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTg5MzhmZjgwZjZhZDlkOGNkMDdjYmRhNmNjMzY1NDRhODMzZWRjYjkwZGIxNzE4NWY3NGFlNDgxNTI3NTBkYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.3Y9jZFBBEilijDXes_ba1bsX1lqOC0SyfCAc-8xSAk4)
![Error screenshot 5 (exception)](https://private-user-images.githubusercontent.com/3993179/303841197-dfe4e02d-5710-4b30-b6b1-6fcf9144dc30.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTE5Ny1kZmU0ZTAyZC01NzEwLTRiMzAtYjZiMS02ZmNmOTE0NGRjMzAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTNkZmNlYzg5MWJmZGQzYjllYjg4MWFmMmE3NjBkMDBlMzIzMTJiM2RjYzIzYzA5MTNiOTc4Mjc2NDgyYzVmOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.egzplkJO5qrjEqFGjB2mTCxlmrlUbPqlz93N-5-2hUk)
I added line 45 just like in
![Error screenshot 6 (npm)](https://private-user-images.githubusercontent.com/3993179/303841377-55449327-c07d-4950-80c1-5208d84e7294.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTM3Ny01NTQ0OTMyNy1jMDdkLTQ5NTAtODBjMS01MjA4ZDg0ZTcyOTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmNjMmUwMGNhN2JhZjcxZGUyZmYxZWNiZWZkMGFlZTM1YzQyMTBkY2Y3N2RkYjcxYjExODg4YWYzNjg3NjE1NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.s3Ded_DAG-K2NXM54iMUoVsNxxcasaBZbbTVs2Qr2vk)
PythonPlugin.cs
and this exception disappeared. Even though the exception disappeared, plugins still don't work, now for another reason: they except the JSON they receive to have lower-case keys, and they receive them capitalized (Method
instead ofmethod
,Parameters
instead ofparameters
etc). Now they just don't respond with anything.After I added the same serialization options that were used for C# and Python plugins (lines 31 and 38), Nodejs plugins started working:
![Success screenshot 1 (beat)](https://private-user-images.githubusercontent.com/3993179/303841501-4393d9a0-e970-47de-b137-56f514591e18.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTUwMS00MzkzZDlhMC1lOTcwLTQ3ZGUtYjEzNy01NmY1MTQ1OTFlMTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTg5YmZkZTkzYTBiNTQyNTdlN2Q5N2IzYzkyMDhjY2MzMTU3Y2UyNjZkZDI4ZDE1NzNlMGU2MjI4N2Q3NjUxYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.P7SoC74QGZhi73xYeybkuhF798jaskvZEdxO1hjHNak)
![Success screenshot 2 (hn)](https://private-user-images.githubusercontent.com/3993179/303841503-d626990d-d0a5-4f2c-9ac1-3c969b12803d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTUwMy1kNjI2OTkwZC1kMGE1LTRmMmMtOWFjMS0zYzk2OWIxMjgwM2QucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTI1N2ViNmNlZDQyNDQzMmU4Njk4ZTc4ODEzNzU2YzY5ZjdhMWEwMTIzMjc4ZjQ4M2QxNzdhMWEzMGU3YmU3MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.AcaLckBKkWRedF0bul14QI_hnvh74CNmMgVw04VNnVw)
![Success screenshot 3 (npm)](https://private-user-images.githubusercontent.com/3993179/303841505-1688700f-4c67-4bca-a4bf-aa5ef07eae47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzk1OTgsIm5iZiI6MTcyMTEzOTI5OCwicGF0aCI6Ii8zOTkzMTc5LzMwMzg0MTUwNS0xNjg4NzAwZi00YzY3LTRiY2EtYTRiZi1hYTVlZjA3ZWFlNDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTQxNDU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzYwYTc2ZGRkZDAyNGJiNWNjNTkzNDI2Y2JjNmNlODljYjg2ZjY1OTY1OGZiMDJhYmJjY2JhNzBhNzhkNTVmZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.TYh_xpGIPW49jI3XMCcwlKtekdNW5pIrmypqQF7EQTw)