Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove short circuit check for empty Settings #2559

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

Garulf
Copy link
Member

@Garulf Garulf commented Feb 11, 2024

Settings UI is not loading for newly installed plugins due.

A check for empty settings skips loading a plugin's settings UI if empty. However newly installed plugin's always have an empty settings file.

Tested with a newly installed plugin to verify it's settings UI was fully loaded.

@Garulf Garulf added the bug Something isn't working label Feb 11, 2024
@Garulf Garulf added this to the 1.17.2 milestone Feb 11, 2024
@Garulf Garulf self-assigned this Feb 11, 2024
@Garulf Garulf requested a review from jjw24 February 11, 2024 07:37
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

hyperlink
IPublic
linkbtn

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the fix-settings-not-loading branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/7860523894/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor VictoriousRaptor merged commit 492771c into dev Feb 11, 2024
4 checks passed
@VictoriousRaptor VictoriousRaptor deleted the fix-settings-not-loading branch February 11, 2024 07:51
@jjw24 jjw24 mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants