Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program indexing logic when cache is empty #2625

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Mar 31, 2024

#2508 (comment)

Reindex during initializing Program Plugin, when win32 OR uwp cache is empty, instead of both are empty.

Downside: When user choose not to index uwp in plugin settings, reindex is unnecessary.

Not dev only. it's in release as well.

This comment has been minimized.

@jjw24 jjw24 added the Dev branch only An issue or fix for the Dev branch build label Mar 31, 2024
@jjw24 jjw24 added this to the 1.18.0 milestone Mar 31, 2024
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (5)

dlgtitle
flowlauncher
IPlugin
Reloadable
Segoe

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the fix-programs-indexing branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8498026002/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor VictoriousRaptor marked this pull request as ready for review March 31, 2024 12:19
@VictoriousRaptor VictoriousRaptor added bug Something isn't working and removed Dev branch only An issue or fix for the Dev branch build labels Mar 31, 2024
@taooceros taooceros merged commit 62a7d9a into dev Mar 31, 2024
4 checks passed
@taooceros taooceros deleted the fix-programs-indexing branch March 31, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants