Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Explorer Preview Panel #2679

Merged
merged 12 commits into from
May 25, 2024

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Apr 30, 2024

What's the PR

  • The preview shows the file size and the dates it was created and modified.
  • This item can be turned on and off by the user. All three are turned on and off at once.
  • General > Show details in preview area (on/off). Default is off.

ETC

  • If we need more in the future, we may need to turn them on and off on a per-item basis.
    • Media Lengh...?
  • We might need a separate settings page for the preview area. (not now...)
  • Users may want to change the timeformat, but this is how we'll proceed for now.

Test Cases

  • It should be on and off depending on settings.
  • Items with no file size information(ex>folder) should not be visible at all.
  • Colors should display properly even if the theme changes.

Todo

  • Check ResultManager.cs logic
  • Can we add folder created/modifed date? (Folder size is not considered. This is usually computationally intensive.)

@onesounds onesounds self-assigned this Apr 30, 2024
@onesounds onesounds added the kind/ux related to user experience label Apr 30, 2024

This comment has been minimized.

@VictoriousRaptor
Copy link
Contributor

IMO the implementation of preview panel should be moved to explorer plugin. it's all about files.

@Yusyuriv Yusyuriv self-assigned this May 20, 2024
@Yusyuriv
Copy link
Member

I moved the new functionality into the Explorer plugin itself.

I have a few issues with the way the date is currently displayed:

  1. I think yy-M-dd date format is very confusing. It's 24-5-20 right now. I would strongly prefer yyyy-MM-dd (2024-05-20) or an option in the settings for the user to be able to customize it.
  2. Same with time. hh:mm displays time in 12-hour format, but it doesn't specify AM/PM. At the very least it should display AM/PM (add tt at the end), but there's a problem: with CultureInfo.CurrentCulture, it does translate the date, but in my CurrentCulture AM/PM doesn't exist, we use 24-hour clock, so I get an empty space where AM/PM should be if I add tt in the format.

@onesounds
Copy link
Contributor Author

Let's add the Show Toggle option and DateTimeFormat in plugin setting.

@Yusyuriv
Copy link
Member

Time formats and date formats in Settings.cs probably need some adjustments.

@taooceros taooceros changed the title Improve Basic Preview Panel Improve Explorer Preview Panel May 24, 2024
@onesounds
Copy link
Contributor Author

There's a separator color issue, which I'll fix in a separate PR. (Previously, I didn't want to add a style to the separator color, so I made it get the color from the already assigned separator. Changing to panels in this PR is causing this color to not be imported. Need to add a separate style).

@onesounds onesounds merged commit 3436c57 into Flow-Launcher:dev May 25, 2024
3 checks passed
@jjw24 jjw24 added the enhancement New feature or request label May 25, 2024
@jjw24 jjw24 added this to the 1.19.0 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/ux related to user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants