-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove top margin of General tab (Settings) #495
Remove top margin of General tab (Settings) #495
Conversation
Why: for similar UX to other apps/website
@pc223 's two changes seem to make our setting panel not appears only have one page. Do we still want to hide scroller by default? @Flow-Launcher/Team |
I too prefer to remove the option auto-hide scrollbar in the settings, and set the default to hide scrollbar, I think with some visual trick, we can make users aware of the scrolling space 😄 Provide options for these kinds of thing is seems a bit overkill IMO |
I disagree - I think the scroll bar should be visible by default and large enough to show users there are more options below. |
The Plugin tab and Theme tab still hide the scrollbar by default, and Windows 10 settings and Start menu seems to hide scrollbar too. It's pretty common style in Windows 10. I think users get confuse because 2 margins that cause users to think it's unscrollable space 😄 |
The plugin and theme tabs have the left scroll area which aren't hidden. All I know is I used Wox/Flow for a while before I realised you could scroll in the settings tab (even then it was only when it came up on Discord). We have to have a clear way to show users to scroll for more settings. |
Yes, before the removing of 2 top and bottom margins, it looks like the settings is unscrollable. But if you remove those margins, it look really clear that this is scrollable space. Before it looks like this |
I see what you mean, it certainly is an improvement. Let's implement and see what the feedback is. |
Theme and plugin tabs should mirror the main settings tab in terms hiding or not hiding the scrollbar. By default the scrollbar is shown, this is not the case? |
Oh yeah, apparently it mirrors the auto-hide scroll bar settings, sorry, I never turn off auto-hide so I never see them in Theme or Plugins haha 😅 |
Why?
Seems cleaner and similar UX to other apps/website
Before:
![](https://user-images.githubusercontent.com/10551242/123534012-0cf40a00-d744-11eb-85c9-5f71df79d5f2.gif)
After:
![](https://user-images.githubusercontent.com/10551242/123534019-141b1800-d744-11eb-8cac-a2e308312b88.gif)