Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename containers 2 #117

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Rename containers 2 #117

merged 1 commit into from
Feb 19, 2024

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/admin#212

Description

Not to be merged before #116

Related Issue(s)

FlowFuse/admin#212

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.0 milestone Jan 11, 2024
@hardillb hardillb self-assigned this Jan 11, 2024
knolleary
knolleary requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FlowFuse org on dockerhub has its own set of credentials

@hardillb hardillb marked this pull request as ready for review January 29, 2024 10:15
@hardillb hardillb mentioned this pull request Jan 29, 2024
Merged
@knolleary knolleary self-requested a review February 5, 2024 16:58
@hardillb hardillb marked this pull request as draft February 16, 2024 10:43
@hardillb hardillb marked this pull request as ready for review February 16, 2024 10:44
@hardillb
Copy link
Contributor Author

This is still showing changes that are already merged into the build-containers.yml action file.

@hardillb
Copy link
Contributor Author

@knolleary When you get a second can you review this please.

@hardillb hardillb merged commit 5f7ed0a into main Feb 19, 2024
@hardillb hardillb deleted the rename-containers-2 branch February 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@ppawlowski ppawlowski ppawlowski approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hardillb @knolleary @ppawlowski