Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer vs Node-RED fidelity improvements #21

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

Steve-Mcl
Copy link
Contributor

Description

General rendering improvements including:

  • More accurate in/out port rendering
  • core tcp and udp nodes now rendered
  • Use topic for label when no other label defined (core nodes) Many nodes now get more accurate labels
  • icon positioning correction
  • grid snapping to improve Nodes do not snap to grid like node-red and as such, layout differs #20
  • fixes bugs related to original flow object being mutated (original flows were not cloned)

BEFORE

image

AFTER

image

Related Issue(s)

#20

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

More accurate in/out port rendering
core tcp and udp nodes now rendered
Use topic for label when no other label defined (core nodes)
Many nodes now get more accurate labels
icon positioning correction
grid snapping to improve #20
fixes bugs related to original flow object being mutated (original flows were not cloned)
@Steve-Mcl Steve-Mcl merged commit fb76a4d into main Apr 27, 2024
@Steve-Mcl Steve-Mcl deleted the rendering-improvements branch April 27, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants