Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: script later is module too #27

Merged
merged 3 commits into from
May 1, 2024
Merged

docs: script later is module too #27

merged 3 commits into from
May 1, 2024

Conversation

ZJvandeWeg
Copy link
Member

Description

While it was clear in the documentation that loading the index.js needs a type="module" in the script tag, it didn't register to me the later version needed too. This change breaks JS highlighting, but would've saved me an hour. (I don't know JS, so maybe this PR isn't needed?)

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

README.md Outdated Show resolved Hide resolved
@Steve-Mcl Steve-Mcl merged commit ab2beee into main May 1, 2024
@Steve-Mcl Steve-Mcl deleted the ZJvandeWeg-patch-1 branch May 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants