Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatar lettering is mis-allinged when only rendering 1 character #1038

Closed
Steve-Mcl opened this issue Oct 3, 2022 · 4 comments · Fixed by #1117
Closed

avatar lettering is mis-allinged when only rendering 1 character #1038

Steve-Mcl opened this issue Oct 3, 2022 · 4 comments · Fixed by #1117
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working size:XS - 1 Sizing estimation point
Milestone

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

Avatars for users t4 and test 6 are not rendered correctly

image

Expected Behavior

All allowable alpha numeric characters should rendered OR center the single character

Steps To Reproduce

create a user named t4 or test 6

Environment

  • FlowForge version: 0.10.0
  • Platform/OS: Windows / Linux
  • Browser: All
@Steve-Mcl Steve-Mcl added the needs-triage Needs looking at to decide what to do label Oct 3, 2022
@knolleary knolleary added the size:XS - 1 Sizing estimation point label Oct 21, 2022
@knolleary knolleary added this to the 1.0 milestone Oct 21, 2022
@Steve-Mcl
Copy link
Contributor Author

@knolleary Hi Nick, happy to pick this up but would be a good leg up if I knew the font-set used (or procedure) to generate the missing number characters in: https://github.com/flowforge/flowforge/blob/main/forge/routes/ui/avatar.js#L39

@knolleary
Copy link
Member

@Steve-Mcl tbh I cannot immediately remember where they came from, would need to dig around.

But this issue doesn't ask for additional characters to be added to the font. It is the issue that a single char doesn't get centrally aligned. That should be a quick fix.

@Steve-Mcl
Copy link
Contributor Author

Ahha - it was. In the (slightly misleading) "expected behavior" caption "All allowable alpha numeric characters should rendered" 🤣🤣

TBH, I suspect adding the numbers is the better fix as it not too uncommon for users to have projects named "Server 1" and "Server 2" which would both have avatars of ( S )

If you dont have the info to hand - I wont waste time trying to "fit up" a matching font for the missing numbers - but rather centralise the single character & follow it up with a new issue to catch this later

Let me know if you stumble across the font set or procedure pls.

Ta.

@Steve-Mcl
Copy link
Contributor Author

Verified on staging

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working size:XS - 1 Sizing estimation point
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants