Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowforge-nr-launcher missing try/catch on http request #1096

Closed
hardillb opened this issue Oct 19, 2022 · 4 comments · Fixed by FlowFuse/nr-launcher#74
Closed

flowforge-nr-launcher missing try/catch on http request #1096

hardillb opened this issue Oct 19, 2022 · 4 comments · Fixed by FlowFuse/nr-launcher#74
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hardillb
Copy link
Contributor

Current Behavior

FlowFuse/docker-compose#45

If api_url is wrong (or forge app is down) the the got request to get settings will fail and crash with hard to decipher stacktrace

Expected Behavior

Catch the error and log suitable message.

Probably exit nr-launcher cleanly (localfs and k8s drivers will automatically try and restart after suitable backoff time, need to check docker)

Steps To Reproduce

In docker-compose etc/flowforge.yml change the api_url

Environment

  • FlowForge version: 0.10.0
  • Node.js version: 16.x
  • npm version: 8.x
  • Platform/OS: docker
  • Browser: na
@hardillb hardillb added the needs-triage Needs looking at to decide what to do label Oct 19, 2022
@knolleary knolleary added this to the 1.0 milestone Oct 19, 2022
@knolleary knolleary added bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Oct 19, 2022
@hardillb hardillb self-assigned this Oct 19, 2022
hardillb added a commit to FlowFuse/nr-launcher that referenced this issue Oct 20, 2022
@Steve-Mcl
Copy link
Contributor

verified on local only.
killing forge app does not cause exception in launcher.

@Steve-Mcl
Copy link
Contributor

@knolleary @hardillb not sure we can test this on staging?
Should we consider this fairly innocuous PR "done"?

@knolleary
Copy link
Member

Yes

@hardillb
Copy link
Contributor Author

Ship it, you need to set a bad api_url which I can't remember if localfs uses

I will break a docker build when I feel better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants