We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlowFuse/docker-compose#45
If api_url is wrong (or forge app is down) the the got request to get settings will fail and crash with hard to decipher stacktrace
api_url
Catch the error and log suitable message.
Probably exit nr-launcher cleanly (localfs and k8s drivers will automatically try and restart after suitable backoff time, need to check docker)
In docker-compose etc/flowforge.yml change the api_url
etc/flowforge.yml
The text was updated successfully, but these errors were encountered:
Have loadSettings fail gracefully
1c66da0
fixes FlowFuse/flowfuse#1096
verified on local only. killing forge app does not cause exception in launcher.
Sorry, something went wrong.
@knolleary @hardillb not sure we can test this on staging? Should we consider this fairly innocuous PR "done"?
Yes
Ship it, you need to set a bad api_url which I can't remember if localfs uses
I will break a docker build when I feel better
hardillb
Successfully merging a pull request may close this issue.
Current Behavior
FlowFuse/docker-compose#45
If
api_url
is wrong (or forge app is down) the the got request to get settings will fail and crash with hard to decipher stacktraceExpected Behavior
Catch the error and log suitable message.
Probably exit nr-launcher cleanly (localfs and k8s drivers will automatically try and restart after suitable backoff time, need to check docker)
Steps To Reproduce
In docker-compose
etc/flowforge.yml
change theapi_url
Environment
The text was updated successfully, but these errors were encountered: