Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS SQL Server Support preparation: targeted tests #3696

Closed
Tracked by #3671
Steve-Mcl opened this issue Apr 8, 2024 · 2 comments · Fixed by #3700
Closed
Tracked by #3671

MS SQL Server Support preparation: targeted tests #3696

Steve-Mcl opened this issue Apr 8, 2024 · 2 comments · Fixed by #3700
Assignees

Comments

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Apr 8, 2024

In the discovery made during the POC carried out as part of #3689, some tables cascades need to be removed to prevent errors around self-referencing, cycles and multiple cascade paths. For this, I have added a new task that should be addressed and merged before any other. This task "targeted tests" should explicitly test the cascades and any other DB changes proposed in the branch developed for #3689. No MSSQL specific changes should be merged until these targeted tests are merged and passing for PG and SQLite.

@Steve-Mcl Steve-Mcl changed the title targeted tests *1 MS SQL Server Support preparation: targeted tests Apr 8, 2024
@Steve-Mcl Steve-Mcl self-assigned this Apr 8, 2024
@Steve-Mcl
Copy link
Contributor Author

Acceptance Criteria: the below tables cascades will need to be modified and should therefore have explicit tests before merging any changes for MSSQL

  • ProjectStacks
  • ProjectTypes
  • Projects
  • DeviceGroups
  • Devices
  • ProjectSnapshots
  • PipelineStages

@Steve-Mcl Steve-Mcl linked a pull request Apr 8, 2024 that will close this issue
11 tasks
@Steve-Mcl
Copy link
Contributor Author

Just additional tests - no application logic was changed. Moving to "Done"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant