-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit relationship tests prior to adding MSSQL support #3700
Conversation
This is ensure changes made to models for supporting MSSQL have no adverse affect
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
+ Coverage 41.80% 41.84% +0.03%
==========================================
Files 630 630
Lines 24459 24459
Branches 5993 5993
==========================================
+ Hits 10226 10235 +9
+ Misses 14233 14224 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that one question
Description
Explicit tests to ensure changes made to models for supporting MSSQL have no adverse affect.
Therefore it is important this PR is passing and merged before any introduction of MSSQL specific works derived from #3689
The tables that are affected by the MSSQL branch are:
The tests added check every relation on these tables.
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label