Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed member notification references member by UUID #833

Closed
ZJvandeWeg opened this issue Aug 1, 2022 · 4 comments · Fixed by #834
Closed

Removed member notification references member by UUID #833

ZJvandeWeg opened this issue Aug 1, 2022 · 4 comments · Fixed by #834
Assignees
@sammachin
Labels
bug Something isn't working
Milestone
0.8

Comments

@ZJvandeWeg
Copy link
Member

ZJvandeWeg commented Aug 1, 2022 •
edited by sammachin

Current Behavior

When a member is removed a notification is shown which member is removed. The removed member is referenced by UUID, not by their name.

Expected Behavior

The notification either shows their name or "This member has been removed"

Steps To Reproduce

Remove a member from a team

Environment

  • FlowForge version: 0.7.0
  • Node.js version: 16.15
  • npm version:
  • Platform/OS:
  • Browser:
@ZJvandeWeg ZJvandeWeg added the needs-triage Needs looking at to decide what to do label Aug 1, 2022
@sammachin sammachin added the bug Something isn't working label Aug 1, 2022
@sammachin
Copy link
Contributor

Recreated on staging video attached

Screen.Cast.2022-08-01.at.2.21.39.PM.mp4

@sammachin
Copy link
Contributor

Need to review other notifications to check what object property they display

@sammachin
Copy link
Contributor

Alerts were introduced in #713

Looks like most of the alerts don't include any object specific information, but there are a couple there to review.

@sammachin sammachin self-assigned this Aug 1, 2022
@sammachin sammachin added this to the 0.8 milestone Aug 1, 2022
@sammachin sammachin removed the needs-triage Needs looking at to decide what to do label Aug 1, 2022
@sammachin
Copy link
Contributor

sammachin commented Aug 1, 2022 •
edited

Have reviewed the code for all instances of alerts.emit there are only 3 places that use any variables in the list,
frontend/src/pages/team/dialogs/InviteMemberDialog.vue Uses the value entered by the user in the input field
And this one in frontend/src/pages/team/dialogs/ConfirmTeamUserRemoveDialog.vue
All others are fixed strings
https://github.com/flowforge/flowforge/search?p=2&q=alerts.emit

@sammachin sammachin mentioned this issue Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sammachin sammachin

Labels
bug Something isn't working
Projects
🛠 Development
Archived in project
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Show username instead of ID in alert on removal FlowFuse/flowfuse
2 participants
@sammachin @ZJvandeWeg