Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast Alerts #713

Merged
merged 8 commits into from Jun 30, 2022
Merged

Toast Alerts #713

merged 8 commits into from Jun 30, 2022

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Jun 21, 2022

Dependent upon: FlowFuse/forge-ui-components#24

first half of #515 (see this issue for a screen recording demo)

@joepavitt
Copy link
Contributor Author

Expecting build to fail at the moment (PR still in draft state) as I'm still referencing my local forge-ui-components in the package json

@joepavitt joepavitt marked this pull request as ready for review June 22, 2022 09:38
@joepavitt joepavitt requested a review from knolleary June 22, 2022 09:41
@joepavitt
Copy link
Contributor Author

joepavitt commented Jun 22, 2022

@knolleary this seems like a big PR, but it's mostly just the injection of alerts.emit() in relevant places.

The guts of the architecture can be found in:

@joepavitt joepavitt mentioned this pull request Jun 22, 2022
@knolleary
Copy link
Member

The basic mechanism looks good. Not 100% on the appearance yet - but we can refine later.

Would be good to capture some docs on how to use it and guidelines on when to use it. I know there are a bunch of actions being added in my various PRs that'll merge over the coming days before 0.7 that will need updating to incorporate it.

@knolleary knolleary merged commit 8f65077 into main Jun 30, 2022
@knolleary knolleary deleted the toast-alerts branch June 30, 2022 09:56
@joepavitt
Copy link
Contributor Author

Thanks @knolleary - actually agree on the appearance. I went for the generic toast appearance just to get something in, but it does feel out of place with the rest of the UI which I find a lot cleaner/slicker. Will happily iterate.

All available in Figma if you did want to play yourself too.

@joepavitt
Copy link
Contributor Author

RE: Docs - I have been thinking quite a bit about this, and in particular, where that should live. I feel like a natural home is actually the handbook under a "Design Language" section? Doesn't quite feel right in forge-ui-components as it's about more than just the raw Vue components.

@ZJvandeWeg ZJvandeWeg added this to the 0.7 milestone Jul 5, 2022
@knolleary knolleary linked an issue Jul 5, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebrand: Notifications/Pending Actions
3 participants