Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Viewer role #1005

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Add Viewer role #1005

merged 3 commits into from
Sep 22, 2022

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Sep 21, 2022

Adds a Viewer role to the platform.

They are full members of a team, but with read-only access to everything.


Remaining work:

  • tests around api access. Not sure how extensive to make it yet as needsPermission does all the heavy lifting
  • doc updates
  • give user read-only access to the editor

@knolleary knolleary changed the base branch from main to add-hasperms September 21, 2022 16:57
@knolleary knolleary changed the base branch from add-hasperms to main September 22, 2022 10:35
@knolleary knolleary marked this pull request as ready for review September 22, 2022 10:38
@knolleary
Copy link
Member Author

@hardillb I've marked this ready for review, but it isn't ready to merge yet. There will be some doc updates to follow - but wanted to give you the go ahead to start looking at the code. You'll be glad to hear, despite this requiring changes in the oauth flows, they are actually pretty limited in nature.

There will be a companion PR in the nr-auth repo shortly.

@hardillb
Copy link
Contributor

@knolleary OK, will look after lunch

@hardillb hardillb mentioned this pull request Sep 22, 2022
4 tasks
@hardillb
Copy link
Contributor

@knolleary Are you going to add the tests with the doc? Assuming so, happy to merge this

@knolleary
Copy link
Member Author

Yes - the tests will be more around the invitation workflow that is coming in a later pr

@hardillb hardillb merged commit fba150d into main Sep 22, 2022
@hardillb hardillb deleted the viewer-role branch September 22, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants