First pass at Coupon support #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, works, but might want a little UI polishing, I've picked what I think are the right classes, but the spacing might be a little off |
sammachin
approved these changes
Sep 22, 2022
knolleary
requested changes
Sep 22, 2022
frontend/src/pages/team/Billing.vue
Outdated
| if (err.response.status === 404) { | ||
| // check for 402 and redirect if 402 returned | ||
| if (err.response.status === 402) { | ||
| this.coupon = (await window.cookieStore.get('ff_coupon'))?.value.split('.')[0] |
There was a problem hiding this comment.
window.cookieStore is not supported widely enough for us to use - https://developer.mozilla.org/en-US/docs/Web/API/CookieStore#browser_compatibility
There was a problem hiding this comment.
OK, will have to write a function to work with document.cookie - https://www.w3schools.com/js/js_cookies.asp
There was a problem hiding this comment.
Pushed update without window.cookieStore
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Should now work everywhere
knolleary
reviewed
Sep 23, 2022
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
knolleary
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://forge.example.com/account/create?code=[CouponCode]
Sets the
ff_couponcookie with a week long lifecloses #978