Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for static outbound ips #1020

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

robmarcer
Copy link
Contributor

No description provided.

52.215.205.23
54.75.12.35
54.78.87.6
54.216.142.246
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
54.216.142.246

Outbound connections from FlowForge will always come from one of the IP addresses listed below. This can make access to a remote database or corporate network possible where those systems are protected by IP address filtering firewalls. As mentioned in HTTP above, incoming connections MUST be to the hostname not the IP address.

3.250.182.143
52.215.205.23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
52.215.205.23

As mentioned in HTTP above incoming connections MUST be to the hostname not the IP address. In addition the Source IP address of any outgoing connections cannot be guaranteed and may change at any time, therefore this should not be used to validate requests.
Outbound connections from FlowForge will always come from one of the IP addresses listed below. This can make access to a remote database or corporate network possible where those systems are protected by IP address filtering firewalls. As mentioned in HTTP above, incoming connections MUST be to the hostname not the IP address.

3.250.182.143
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3.250.182.143

3.250.182.143
52.215.205.23
54.75.12.35
54.78.87.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
54.78.87.6

@robmarcer
Copy link
Contributor Author

@sammachin sorry I missed your suggested edits so redid them. I update to show the correct IP inline in the sentence and made all references to IP addresses singular.

@robmarcer robmarcer merged commit d516c89 into main Sep 27, 2022
@Pezmc Pezmc deleted the update-docs-for-static-outbound-ips branch October 19, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants